From: Jon Humphreys <j-humphreys@ti.com>
To: Jerome Forissier <jerome.forissier@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: <u-boot@lists.denx.de>, Javier Tia <javier.tia@linaro.org>,
Raymond Mao <raymond.mao@linaro.org>,
Maxim Uvarov <muvarov@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Anton Antonov <Anton.Antonov@arm.com>,
"Joe Hershberger" <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v11 20/29] net-lwip: lwIP wget supports user defined port in the uri, so allow it.
Date: Fri, 4 Oct 2024 22:26:53 -0500 [thread overview]
Message-ID: <86plof8c1u.fsf@udb0321960.dhcp.ti.com> (raw)
In-Reply-To: <06ee18ff-e25d-4e66-ab80-b4ae0bd2574a@linaro.org>
Jerome Forissier <jerome.forissier@linaro.org> writes:
> On 10/4/24 09:11, Ilias Apalodimas wrote:
>> On Thu, 3 Oct 2024 at 18:47, Jerome Forissier
>> <jerome.forissier@linaro.org> wrote:
>>>
>>> From: Jonathan Humphreys <j-humphreys@ti.com>
>>
>> A short description is missing here
>
> I will fold this patch into the previous one since it was a review
> comment from Jonathan H. ; Jonathan I hope you don't mind?
>
No problem.
Jon
> Thanks,
> --
> Jerome
>
>>
>> Thanks
>> /Ilias
>>>
>>> Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com>
>>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
>>> ---
>>> net/lwip/wget.c | 6 ------
>>> 1 file changed, 6 deletions(-)
>>>
>>> diff --git a/net/lwip/wget.c b/net/lwip/wget.c
>>> index e8768fc2acd..b495ebd1aa9 100644
>>> --- a/net/lwip/wget.c
>>> +++ b/net/lwip/wget.c
>>> @@ -349,12 +349,6 @@ bool wget_validate_uri(char *uri)
>>> ret = false;
>>> goto out;
>>> }
>>> - s = strchr(authority, ':');
>>> - if (s) {
>>> - log_err("user defined port is not supported\n");
>>> - ret = false;
>>> - goto out;
>>> - }
>>>
>>> out:
>>> free(str_copy);
>>> --
>>> 2.40.1
>>>
next prev parent reply other threads:[~2024-10-05 3:27 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 15:22 [PATCH v11 00/29] Introduce the lwIP network stack Jerome Forissier
2024-10-03 15:22 ` [PATCH v11 01/29] net: recv(): return -EAGAIN instead of 0 when no cleanup is expected Jerome Forissier
2024-10-09 1:51 ` Simon Glass
2024-10-09 9:39 ` Jerome Forissier
2024-10-03 15:22 ` [PATCH v11 02/29] Make AVB_VERIFY depend on FASTBOOT Jerome Forissier
2024-10-09 1:51 ` Simon Glass
2024-10-09 12:31 ` Jerome Forissier
2024-10-03 15:22 ` [PATCH v11 03/29] linker_lists: set LINKER_LIST_ALIGN to 8 for CPU_MIPS64 Jerome Forissier
2024-10-04 7:12 ` Ilias Apalodimas
2024-10-04 12:04 ` Heinrich Schuchardt
2024-10-04 12:55 ` Jerome Forissier
2024-10-04 18:28 ` Tom Rini
2024-10-10 13:29 ` Jerome Forissier
2024-10-07 15:23 ` Simon Glass
2024-10-03 15:22 ` [PATCH v11 04/29] sandbox: add dummy driver ETH_SANDBOX_LWIP Jerome Forissier
2024-10-04 7:13 ` Ilias Apalodimas
2024-10-09 1:55 ` Simon Glass
2024-10-03 15:22 ` [PATCH v11 05/29] test: boot: fix bootdev_test_any for when DSA_SANDBOX is disabled Jerome Forissier
2024-10-09 1:51 ` Simon Glass
2024-10-03 15:22 ` [PATCH v11 06/29] test: boot: fix bootflow_cmd_label " Jerome Forissier
2024-10-04 6:55 ` Ilias Apalodimas
2024-10-04 8:46 ` Jerome Forissier
2024-10-04 9:37 ` Ilias Apalodimas
2024-10-04 12:01 ` Jerome Forissier
2024-10-07 15:23 ` Simon Glass
2024-10-08 8:49 ` Jerome Forissier
2024-10-03 15:22 ` [PATCH v11 07/29] net: introduce alternative implementation as net-lwip/ Jerome Forissier
2024-10-03 15:22 ` [PATCH v11 08/29] configs: replace '# CONFIG_NET is not set' with CONFIG_NO_NET=y Jerome Forissier
2024-10-03 15:22 ` [PATCH v11 09/29] net: split include/net.h into net{, -common, -legacy, -lwip}.h Jerome Forissier
2024-10-04 6:00 ` Ilias Apalodimas
2024-10-03 15:22 ` [PATCH v11 10/29] net: move copy_filename() to new file net/net-common.c Jerome Forissier
2024-10-04 6:52 ` Ilias Apalodimas
2024-10-04 8:01 ` Jerome Forissier
2024-10-03 15:22 ` [PATCH v11 11/29] net: eth-uclass: add function eth_start_udev() Jerome Forissier
2024-10-04 6:04 ` Ilias Apalodimas
2024-10-03 15:46 ` [PATCH v11 12/29] net-lwip: build lwIP Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 13/29] net-lwip: add DHCP support and dhcp commmand Jerome Forissier
2024-10-04 6:50 ` Ilias Apalodimas
2024-10-04 8:43 ` Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 14/29] lwip: tftp: bind to TFTP port only when in server mode Jerome Forissier
2024-10-04 6:11 ` Ilias Apalodimas
2024-10-04 9:07 ` Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 15/29] net-lwip: add TFTP support and tftpboot command Jerome Forissier
2024-10-04 12:02 ` Ilias Apalodimas
2024-10-03 15:46 ` [PATCH v11 16/29] net-lwip: add ping command Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 17/29] net-lwip: add dns command Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 18/29] net: split cmd/net.c into cmd/net.c and cmd/net-common.c Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 19/29] net-lwip: add wget command Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 20/29] net-lwip: lwIP wget supports user defined port in the uri, so allow it Jerome Forissier
2024-10-04 7:11 ` Ilias Apalodimas
2024-10-04 8:36 ` Jerome Forissier
2024-10-05 3:26 ` Jon Humphreys [this message]
2024-10-03 15:46 ` [PATCH v11 21/29] cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 22/29] configs: add qemu_arm64_lwip_defconfig Jerome Forissier
2024-10-03 16:44 ` Ilias Apalodimas
2024-10-03 15:46 ` [PATCH v11 23/29] lwip: tftp: add support of blksize option to client Jerome Forissier
2024-10-04 6:41 ` Ilias Apalodimas
2024-10-03 15:46 ` [PATCH v11 24/29] net-lwip: add TFTP_BLOCKSIZE Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 25/29] CI: add qemu_arm64_lwip to the test matrix Jerome Forissier
2024-10-04 6:05 ` Ilias Apalodimas
2024-10-04 18:25 ` Tom Rini
2024-10-07 9:00 ` Jerome Forissier
2024-10-03 15:46 ` [PATCH v11 26/29] MAINTAINERS: net-lwip: add myself as a maintainer Jerome Forissier
2024-10-03 16:02 ` Ilias Apalodimas
2024-10-03 15:46 ` [PATCH v11 27/29] configs: use syntax CONFIG_FOO=n in tools-only_defconfig Jerome Forissier
2024-10-04 6:01 ` Ilias Apalodimas
2024-10-03 15:47 ` [PATCH v11 28/29] [TESTING] configs: set CONFIG_NET=y for FTGMAC100 Jerome Forissier
2024-10-04 6:05 ` Ilias Apalodimas
2024-10-03 15:47 ` [PATCH v11 29/29] [TESTING] Kconfig: enable NET_LWIP by default Jerome Forissier
2024-10-03 16:00 ` [PATCH v11 00/29] Introduce the lwIP network stack Ilias Apalodimas
2024-10-03 16:10 ` Jerome Forissier
2024-10-03 16:11 ` Ilias Apalodimas
2024-10-04 18:30 ` Tom Rini
2024-10-04 18:36 ` Ilias Apalodimas
2024-10-07 13:31 ` Jerome Forissier
2024-10-04 19:15 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plof8c1u.fsf@udb0321960.dhcp.ti.com \
--to=j-humphreys@ti.com \
--cc=Anton.Antonov@arm.com \
--cc=ilias.apalodimas@linaro.org \
--cc=javier.tia@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=muvarov@gmail.com \
--cc=raymond.mao@linaro.org \
--cc=rfried.dev@gmail.com \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox