public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>,
	 Patrick Delaunay <patrick.delaunay@foss.st.com>,
	 Marek Vasut <marex@denx.de>,
	 Emil Kronborg <emil.kronborg@protonmail.com>
Subject: Re: [PATCH 0/3] env: mmc: fix use of two separate partitions with proper type GUID
Date: Tue, 01 Oct 2024 15:43:23 +0200	[thread overview]
Message-ID: <871q10j5vo.fsf@prevas.dk> (raw)
In-Reply-To: <20240912134141.4143855-1-rasmus.villemoes@prevas.dk> (Rasmus Villemoes's message of "Thu, 12 Sep 2024 15:41:38 +0200")

Rasmus Villemoes <rasmus.villemoes@prevas.dk> writes:

> I always define a disk layout with two separate partitions for the two
> copies of the U-Boot environment and, being the one who introduced the
> type GUID for such partitions, of course also set those partitions'
> type GUID appropriately.
>
> This has worked just fine, but, it turns out, only because I've never
> had CONFIG_PARTITION_TYPE_GUID enabled on any of my boards; I've
> always just set the offsets of the two partitions via the config
> variables CONFIG_ENV_OFFSET(,_REDUND).
>
> I didn't even know that env/mmc.c had learnt to look for the env
> partition based on the type GUID, or that that would overrule the
> ENV_OFFSET config variables, until I experienced weird random
> corruption while doing bringup for an stm32 board, where
> PARTITION_TYPE_GUID is automatically set because it is select'ed by
> CMD_STM32PROG.
>
> These patches try to fix the code to fit my scheme, while not changing
> anything for existing setups that use the two-copies-one-partition
> scheme, other than complaining loudly if the system is misconfigured
> and avoiding such random corruption of neighbouring partitions.

Tom, any chance these could be picked up before 2024.10 release? And if
not, at least be put in -next so I have some stable sha1s to refer to
in my own branch.

Rasmus

  parent reply	other threads:[~2024-10-01 13:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 13:41 [PATCH 0/3] env: mmc: fix use of two separate partitions with proper type GUID Rasmus Villemoes
2024-09-12 13:41 ` [PATCH 1/3] env: mmc: refactor mmc_offset_try_partition() Rasmus Villemoes
2024-09-18 16:59   ` Quentin Schulz
2024-09-19  6:53     ` Rasmus Villemoes
2024-09-23 11:04       ` Quentin Schulz
2024-09-12 13:41 ` [PATCH 2/3] env: mmc: do not return an offset before the start of the partition Rasmus Villemoes
2024-09-12 13:41 ` [PATCH 3/3] env: mmc: rework mmc_env_partition_by_guid() to work with two separate partitions Rasmus Villemoes
2024-09-18 16:59   ` Quentin Schulz
2024-09-19  7:01     ` Rasmus Villemoes
2024-09-23 11:10       ` Quentin Schulz
2024-10-01 13:43 ` Rasmus Villemoes [this message]
2024-10-01 14:43   ` [PATCH 0/3] env: mmc: fix use of two separate partitions with proper type GUID Tom Rini
2024-10-01 17:37 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q10j5vo.fsf@prevas.dk \
    --to=rasmus.villemoes@prevas.dk \
    --cc=emil.kronborg@protonmail.com \
    --cc=marex@denx.de \
    --cc=patrick.delaunay@foss.st.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox