From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?iso-8859-1?Q?Klotzb=FCcher?= Date: Tue, 28 Nov 2006 22:49:54 +0100 Subject: [U-Boot-Users] [PATCH][RESEND] make y-modem a separate config option In-Reply-To: <1164745557l.7533l.0l@oscar.alarsen.net> (Anders Larsen's message of "Tue, 28 Nov 2006 21:25:57 +0100") References: <1164726672l.6990l.2l@ecxwww1.reanet.de> <87bqmruyji.fsf@denx.de> <1164745557l.7533l.0l@oscar.alarsen.net> Message-ID: <871wnntf5p.fsf@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Anders, Anders Larsen writes: > On 2006-11-28 21:05:53, Markus Klotzb?cher wrote: >> If we do "waste" a config option on this, wouldn't it make sense to >> separate loadb and loady completely, so that either can be chosen >> independently? > > I fully agree - but since loadb and loady share a fair amount of > common code, separating them isn't trivial (without duplicating that > code, which should be avoided). Are you sure? The only common code I see is the command entry point do_load_serial(). Apart from that loady seems it use its own code exclusively (mainly common/xyzModem.c and u-boot-orig/common/crc16.c) Regards Markus Klotzb?cher