* [PATCH] usb: dwc3-meson-g12a: Select PHY instead of imply PHY
@ 2023-02-23 16:32 Marek Vasut
2023-02-24 9:58 ` Mattijs Korpershoek
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2023-02-23 16:32 UTC (permalink / raw)
To: u-boot; +Cc: Marek Vasut, Mattijs Korpershoek, Neil Armstrong, Tom Rini
Imply means you can turn off the option and expect things to work
- "it's a good idea to have X enabled" is when to use imply
- "you must have X for Y to work" is when to use select
Use "select" here.
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Tom Rini <trini@konsulko.com>
---
drivers/usb/dwc3/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index f010291d022..e8373b30bb7 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -40,7 +40,7 @@ config SPL_USB_DWC3_GENERIC
config USB_DWC3_MESON_G12A
bool "Amlogic Meson G12A USB wrapper"
depends on DM_USB && USB_DWC3 && ARCH_MESON
- imply PHY
+ select PHY
help
Select this for Amlogic Meson G12A Platforms.
This wrapper supports Host and Peripheral operation modes.
@@ -48,7 +48,7 @@ config USB_DWC3_MESON_G12A
config USB_DWC3_MESON_GXL
bool "Amlogic Meson GXL USB wrapper"
depends on DM_USB && USB_DWC3 && ARCH_MESON
- imply PHY
+ select PHY
help
Select this for Amlogic Meson GXL and GXM Platforms.
This wrapper supports Host and Peripheral operation modes.
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc3-meson-g12a: Select PHY instead of imply PHY
2023-02-23 16:32 [PATCH] usb: dwc3-meson-g12a: Select PHY instead of imply PHY Marek Vasut
@ 2023-02-24 9:58 ` Mattijs Korpershoek
0 siblings, 0 replies; 2+ messages in thread
From: Mattijs Korpershoek @ 2023-02-24 9:58 UTC (permalink / raw)
To: Marek Vasut, u-boot; +Cc: Marek Vasut, Neil Armstrong, Tom Rini
On jeu., févr. 23, 2023 at 17:32, Marek Vasut <marex@denx.de> wrote:
> Imply means you can turn off the option and expect things to work
> - "it's a good idea to have X enabled" is when to use imply
> - "you must have X for Y to work" is when to use select
>
> Use "select" here.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> drivers/usb/dwc3/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index f010291d022..e8373b30bb7 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -40,7 +40,7 @@ config SPL_USB_DWC3_GENERIC
> config USB_DWC3_MESON_G12A
> bool "Amlogic Meson G12A USB wrapper"
> depends on DM_USB && USB_DWC3 && ARCH_MESON
> - imply PHY
> + select PHY
> help
> Select this for Amlogic Meson G12A Platforms.
> This wrapper supports Host and Peripheral operation modes.
> @@ -48,7 +48,7 @@ config USB_DWC3_MESON_G12A
> config USB_DWC3_MESON_GXL
> bool "Amlogic Meson GXL USB wrapper"
> depends on DM_USB && USB_DWC3 && ARCH_MESON
> - imply PHY
> + select PHY
> help
> Select this for Amlogic Meson GXL and GXM Platforms.
> This wrapper supports Host and Peripheral operation modes.
> --
> 2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-24 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-23 16:32 [PATCH] usb: dwc3-meson-g12a: Select PHY instead of imply PHY Marek Vasut
2023-02-24 9:58 ` Mattijs Korpershoek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox