From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D031EC64ED8 for ; Fri, 24 Feb 2023 09:58:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 36C1485A27; Fri, 24 Feb 2023 10:58:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="UeGd1XJh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0F30A85A2F; Fri, 24 Feb 2023 10:58:47 +0100 (CET) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 53BFA85ADF for ; Fri, 24 Feb 2023 10:58:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wm1-x32d.google.com with SMTP id c18so6388712wmr.3 for ; Fri, 24 Feb 2023 01:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=i7I+r9ycUPi39W100qPH02bNTnN7+ZyEBZYRqV8ck90=; b=UeGd1XJh/GndNrAqOfUV7eLlhCnlYBVfR9FzX7If+D2X14Y8uQoXHbMhDANFwTTv2u 3d58PvhAZ5pM31ZE3aa5T7RsvttqfGZadxW7jP0cCi1XimgQkMUWyiFR2jMujKGRXuFl KT0zQ9MW7WcTFiEIX1TaUUJLyD5sdrFY58YTi+ueHSWRPbKgBrYZ+GVJJqdKqM0mNWej BU7BiYBfjYyy8InEpP3KLHkz6yZmc/OpqcO9kIZY/4RI2U9jMjEqWtPMwYKM4V2WGEio P2E66hC1oEEHR/GtPZq1lqbUClR4FaqOgEIuvTpMqwK3yRHbPVXcPqm1rFabkXEo92xK iXlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i7I+r9ycUPi39W100qPH02bNTnN7+ZyEBZYRqV8ck90=; b=FLm9xMK99fEw+gJ0/UxDfTHEN643tc67QmX29g6Sru/RWNOEeF0mL/qwr0SOEouzmq 6fWeyQI7RK3R+2lacpK+No7RDM7UFuW2+KUvOzK1YYpodU7Qi3JVwANKwD4+jMH+G039 GVaPZdHEBTATkv2HVNMYqX52JBsJTiMpWtcti4/ohmKVS9VrpkKY2xe9bG87own+PWzK LqD3QdYDODDaOcdGVfrOoT5er1PQjEyVlZ8zfmQMrnxm+JZPmwB545AHrOp++SFMLF+Q aEV1UQ/S3O5j1WWvhd8TwvSZfSF6g8Afz3Bxzb3LCLbH9OGwvGow57DFdfa1KIwVmbeO AS3w== X-Gm-Message-State: AO0yUKVSr+S2Z9Vd07jh4xYbuPNeZPgreLvtlt6xg6rl1Fxs0hgWJewE nGAvKhRqSSucUt8VCAQ3aCsZfg== X-Google-Smtp-Source: AK7set/l9TPyp7p6OdA1z8mdK8geQAioKQ2vt+WwysfKq3T3bhT3WwHMshha2IJ1qCjDwdQHaWqmbg== X-Received: by 2002:a05:600c:90a:b0:3eb:2b88:a69a with SMTP id m10-20020a05600c090a00b003eb2b88a69amr209071wmp.14.1677232722538; Fri, 24 Feb 2023 01:58:42 -0800 (PST) Received: from localhost ([2a01:cb19:85e6:1900:2bf7:7388:731d:c4e1]) by smtp.gmail.com with ESMTPSA id a2-20020a05600c348200b003e8f0334db8sm2326106wmq.5.2023.02.24.01.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 01:58:42 -0800 (PST) From: Mattijs Korpershoek To: Marek Vasut , u-boot@lists.denx.de Cc: Marek Vasut , Neil Armstrong , Tom Rini Subject: Re: [PATCH] usb: dwc3-meson-g12a: Select PHY instead of imply PHY In-Reply-To: <20230223163243.46778-1-marex@denx.de> References: <20230223163243.46778-1-marex@denx.de> Date: Fri, 24 Feb 2023 10:58:41 +0100 Message-ID: <87356v4c6m.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On jeu., f=C3=A9vr. 23, 2023 at 17:32, Marek Vasut wrote: > Imply means you can turn off the option and expect things to work > - "it's a good idea to have X enabled" is when to use imply > - "you must have X for Y to work" is when to use select > > Use "select" here. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Mattijs Korpershoek > Cc: Neil Armstrong > Cc: Tom Rini > --- > drivers/usb/dwc3/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index f010291d022..e8373b30bb7 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -40,7 +40,7 @@ config SPL_USB_DWC3_GENERIC > config USB_DWC3_MESON_G12A > bool "Amlogic Meson G12A USB wrapper" > depends on DM_USB && USB_DWC3 && ARCH_MESON > - imply PHY > + select PHY > help > Select this for Amlogic Meson G12A Platforms. > This wrapper supports Host and Peripheral operation modes. > @@ -48,7 +48,7 @@ config USB_DWC3_MESON_G12A > config USB_DWC3_MESON_GXL > bool "Amlogic Meson GXL USB wrapper" > depends on DM_USB && USB_DWC3 && ARCH_MESON > - imply PHY > + select PHY > help > Select this for Amlogic Meson GXL and GXM Platforms. > This wrapper supports Host and Peripheral operation modes. > --=20 > 2.39.1