Re: [PATCH] usb: dwc3-meson-g12a: Select PHY instead of imply PHY

Mattijs Korpershoek
2023-02-24T09:58:51Z

On jeu., févr. 23, 2023 at 17:32, Marek Vasut <marex@denx.de> wrote:

> Imply means you can turn off the option and expect things to work
> - "it's a good idea to have X enabled" is when to use imply
> - "you must have X for Y to work" is when to use select
>
> Use "select" here.
>
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> drivers/usb/dwc3/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index f010291d022..e8373b30bb7 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -40,7 +40,7 @@ config SPL_USB_DWC3_GENERIC
> config USB_DWC3_MESON_G12A
> bool "Amlogic Meson G12A USB wrapper"
> depends on DM_USB && USB_DWC3 && ARCH_MESON
> - imply PHY
> + select PHY
> help
> Select this for Amlogic Meson G12A Platforms.
> This wrapper supports Host and Peripheral operation modes.
> @@ -48,7 +48,7 @@ config USB_DWC3_MESON_G12A
> config USB_DWC3_MESON_GXL
> bool "Amlogic Meson GXL USB wrapper"
> depends on DM_USB && USB_DWC3 && ARCH_MESON
> - imply PHY
> + select PHY
> help
> Select this for Amlogic Meson GXL and GXM Platforms.
> This wrapper supports Host and Peripheral operation modes.
> --
> 2.39.1