From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BA18C4332F for ; Thu, 3 Nov 2022 14:06:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B481085068; Thu, 3 Nov 2022 15:06:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=tkos.co.il header.i=@tkos.co.il header.b="p98iCL+p"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0D31785168; Thu, 3 Nov 2022 15:06:23 +0100 (CET) Received: from mail.tkos.co.il (hours.tkos.co.il [84.110.109.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 38C1E83E57 for ; Thu, 3 Nov 2022 15:06:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=baruch@tkos.co.il Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 2CA75440F39; Thu, 3 Nov 2022 16:03:58 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1667484238; bh=s/vRxT2LGvCJZxW4GD7hJMi9hdaJJj21h30YGhy2DZs=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=p98iCL+p46uardD+cvUSVM40n3/ZgizPo/gj0NCiT5GF76rNjTP4Tg6W9U18XqNAe AKpfwNOA3AhENJFAq6rVvfR2dC8IB0qtnVT0icJd8fHBK254QVu+HyKhdQiEqQsepW qVXspqnm2rEzsSE/aEdpS1NctxwYS0pj20phE/55ASRC8iRjxTqXFDa8iQwNFlZKLM Ca7YsQvz7XdpbrlOWoSFxIflLEXHp6X5TwAt+nbeiBAM24ywq9iKovBOxq242rfU+S BfY4UZ/cOAoptGbEyrOeYhIZMu8KkuhXwkb1i3RopYFMU/oZbgVzn1OTlq5JlCrlMh hG9utvAftt9QA== References: <877d0cp6fg.fsf@tarshish> User-agent: mu4e 1.8.10; emacs 27.1 From: Baruch Siach To: Fabio Estevam Cc: u-boot@lists.denx.de Subject: Re: DM_SERIAL for i.MX6 Hummingboard/Cubox-i Date: Thu, 03 Nov 2022 15:57:41 +0200 In-reply-to: Message-ID: <8735b0p1yd.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Fabio, On Thu, Nov 03 2022, Fabio Estevam wrote: > On Thu, Nov 3, 2022 at 9:29 AM Baruch Siach wrote: >> I am trying to migrate the Hummingboard platform to DM_SERIAL. See below >> what I got so far. Booting this on top of master (as of commit >> 8bc87a4c5) shows nothing on the serial console. Next thing I plan to try >> is toggle GPIOs in entry code to see how far the code proceeds. >> >> Any idea where to look before I go down that way? >> >> Thanks, >> baruch >> >> diff --git a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi >> index 400b885e4370..8507b818d4cf 100644 >> --- a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi >> +++ b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi >> @@ -15,6 +15,10 @@ >> }; >> }; >> >> +&uart1 { >> + u-boot,dm-pre-reloc; >> +}; > > Here you also need to pass &aips1, &pinctrl_uart1, and &soc. I tried this (see below) but no luck yet. The tbs2910 appears not to use SPL. I might be missing an SPL driver. Thanks for your help, baruch diff --git a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi index 400b885e4370..e1cb9b3e89ec 100644 --- a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi +++ b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi @@ -15,6 +15,22 @@ }; }; +&soc { + u-boot,dm-pre-reloc; +}; + +&aips1 { + u-boot,dm-pre-reloc; +}; + +&pinctrl_microsom_uart1 { + u-boot,dm-pre-reloc; +}; + +&uart1 { + u-boot,dm-pre-reloc; +}; + &gpio2 { u-boot,dm-pre-reloc; }; diff --git a/configs/mx6cuboxi_defconfig b/configs/mx6cuboxi_defconfig index 9de5e77c75ad..9d7b2764c969 100644 --- a/configs/mx6cuboxi_defconfig +++ b/configs/mx6cuboxi_defconfig @@ -46,7 +46,6 @@ CONFIG_OF_CONTROL=y CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIST="imx6dl-hummingboard2-emmc-som-v15 imx6q-hummingboard2-emmc-som-v15" CONFIG_MULTI_DTB_FIT=y -CONFIG_SPL_OF_PLATDATA=y CONFIG_ENV_OVERWRITE=y CONFIG_ENV_IS_IN_MMC=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y @@ -65,9 +64,11 @@ CONFIG_FEC_MXC=y CONFIG_RGMII=y CONFIG_MII=y CONFIG_PINCTRL=y +CONFIG_SPL_PINCTRL=y CONFIG_PINCTRL_IMX6=y CONFIG_DM_REGULATOR=y CONFIG_DM_REGULATOR_FIXED=y +CONFIG_DM_SERIAL=y CONFIG_MXC_UART=y CONFIG_DM_THERMAL=y CONFIG_IMX_THERMAL=y > Please look at the following commit for reference: > > commit 8fbca1a8b9b02fbc40147401d9af764e07dc96af > Author: Fabio Estevam > Date: Tue Mar 15 17:47:05 2022 -0300 > > tbs2910: Convert to DM_SERIAL > > Conversion to DM_SERIAL is mandatory. > > Select DM_SERIAL and add a imx6q-tbs2910-u-boot.dtsi file > that describes the nodes that require dm-pre-reloc, which allows > the DM model to configure the UART pinctrl early. > > Remove the now unneeded board UART initialization. > > Signed-off-by: Fabio Estevam > Tested-by: Soeren Moch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -