public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: u-boot@lists.denx.de
Subject: Reproducibility regression with mx6cuboxi
Date: Sun, 26 Jul 2020 11:17:35 -0700	[thread overview]
Message-ID: <87365e6szk.fsf@ponder> (raw)
In-Reply-To: <CAOMZO5AMc6_TOY8-e+q7gVs=AkbVuZPEu9GM17-2bv5UC77BUA@mail.gmail.com>

On 2020-07-26, Fabio Estevam wrote:
> On Sun, Jul 26, 2020 at 2:16 PM Tom Rini <trini@konsulko.com> wrote:
>
>> I mean just literally changing the malloc(...) to calloc(1, ...), audit any
>> other malloc(...) calls in the file and change nothing else.  Thanks!
>
> Thanks for the clarification, Tom
>
> Vagrant,
>
> Does the patch below fix the reproducibility regression?
> https://pastebin.com/raw/MWDUDrJ2

That appears to build reproducibly for me on top of v2020.07. Haven't
tested if the resulting image boots.

FWIW, re-applying Marek's old patch also appeared to fix the
reproducibility issues:

  20a154f95bfe0a3b5bfba90bea7f001c58217536 mkimage: fit: Do not tail-pad
  fitImage with external data

Thanks all, seems a fix is near!


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200726/12932f05/attachment.sig>

  reply	other threads:[~2020-07-26 18:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19 18:23 Reproducibility regression with mx6cuboxi Vagrant Cascadian
2020-07-21 22:24 ` Tom Rini
2020-07-21 22:54   ` Vagrant Cascadian
2020-07-22 18:32 ` Heinrich Schuchardt
2020-07-22 18:44   ` Tom Rini
2020-07-22 20:40     ` Fabio Estevam
2020-07-22 21:10       ` Tom Rini
2020-07-26 14:57         ` Fabio Estevam
2020-07-26 15:05           ` Tom Rini
2020-07-26 17:00             ` Fabio Estevam
2020-07-26 17:15               ` Tom Rini
2020-07-26 17:56                 ` Fabio Estevam
2020-07-26 18:17                   ` Vagrant Cascadian [this message]
2020-07-26 18:22                     ` Fabio Estevam
2020-07-28 11:23                     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87365e6szk.fsf@ponder \
    --to=vagrant@reproducible-builds.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox