From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?iso-8859-1?Q?Klotzb=FCcher?= Date: Wed, 10 Jan 2007 23:01:31 +0100 Subject: [U-Boot-Users] reg ISP 1561 integration with u-boot1.1.6 In-Reply-To: <200701101813.45863.matthias.fuchs@esd-electronics.com> (Matthias Fuchs's message of "Wed, 10 Jan 2007 18:13:45 +0100") References: <4ac2955e0701040358u5699f021o163696f8cf70ba4a@mail.gmail.com> <200701041845.26424.matthias.fuchs@esd-electronics.com> <4ac2955e0701042143w51a8067u80297938c7f4997d@mail.gmail.com> <200701101813.45863.matthias.fuchs@esd-electronics.com> Message-ID: <873b6izglg.fsf@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Matthias, Matthias Fuchs writes: > it's working. I modified the testing-USB branch to run against a PCI OHCI > controller (Philips ISP1561) on the APC405 board (PowerPC PPC405GPr). > > Enumeration and USB storage is working. I do not dare to say 'working well'. > > The main changes concern endianess fixes. The former code only supports OHCI > controller with the same endianess as the CPU. The other fix allows a offset IIRC same problem with the 440EP and MPC5200, thats what the extra #ifdef in drivers/usb_ohci.c:103 is for. > to access the system RAM by the busmastering OHCI controller. I called this > constant CFG_PCIRAM_BASE. But the name is a little bit confusion, isn't it? > > Here are my (first) questions: > 1) What do I have to do in usb_board_stop() and usb_board_init_fail()? > My current code can only initialize the OHCI controller once. A 2nd 'usb > start' does not find any devices. You might not have to do anything, but maybe you'll need to do some board dependant cleanup for example. If not just leave them empty. > 2) I had to disable the 'return -1' statement for an unfinished urb in > sohci_submit_job(). Why isn't it finished? I really don't know, I guess only you can answer this! > Please do not blame me for the board dependent code still in the usb_ohci.c > file. I will move it later. Who else shall we blame then ;-) ? Regards Markus Klotzbuecher