Re: [PATCH v2 8/9] board: stih410-b2260: Remove board_usb_init/cleanup()

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Patrice,

Thank you for the patch.

On jeu., janv. 16, 2025 at 09:17, Patrice Chotard <patrice.chotard@foss.st.com> wrote:

> Since DM_USB_GADGET is enable for this board, board_usb_init()
> and board_usb_cleanup() can be removed.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>

Yay, glad to see some more board_usb_{init,cleanup}() getting removed!

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>
> (no changes since v1)
>
>  board/st/stih410-b2260/board.c | 29 -----------------------------
>  1 file changed, 29 deletions(-)
>
> diff --git a/board/st/stih410-b2260/board.c b/board/st/stih410-b2260/board.c
> index 3a495eb5089..8ad593cccdd 100644
> --- a/board/st/stih410-b2260/board.c
> +++ b/board/st/stih410-b2260/board.c
> @@ -7,10 +7,6 @@
>  #include <cpu_func.h>
>  #include <init.h>
>  #include <asm/cache.h>
> -#include <asm/global_data.h>
> -#include <linux/usb/otg.h>
> -#include <dwc3-uboot.h>
> -#include <usb.h>
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
> @@ -42,31 +38,6 @@ int board_init(void)
>  }
>  
>  #ifdef CONFIG_USB_DWC3
> -static struct dwc3_device dwc3_device_data = {
> -	.maximum_speed = USB_SPEED_HIGH,
> -	.dr_mode = USB_DR_MODE_PERIPHERAL,
> -	.index = 0,
> -};
> -
> -int board_usb_init(int index, enum usb_init_type init)
> -{
> -	int node;
> -	const void *blob = gd->fdt_blob;
> -
> -	/* find the snps,dwc3 node */
> -	node = fdt_node_offset_by_compatible(blob, -1, "snps,dwc3");
> -
> -	dwc3_device_data.base = fdtdec_get_addr(blob, node, "reg");
> -
> -	return dwc3_uboot_init(&dwc3_device_data);
> -}
> -
> -int board_usb_cleanup(int index, enum usb_init_type init)
> -{
> -	dwc3_uboot_exit(index);
> -	return 0;
> -}
> -
>  int g_dnl_board_usb_cable_connected(void)
>  {
>  	return 1;
> -- 
> 2.25.1