From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38832C61DA4 for ; Wed, 22 Feb 2023 21:43:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 23C7685747; Wed, 22 Feb 2023 22:43:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=debian.org header.i=@debian.org header.b="N2/uHn/0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A564F85747; Wed, 22 Feb 2023 22:42:59 +0100 (CET) Received: from cascadia.aikidev.net (cascadia.aikidev.net [173.255.214.101]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7262180ADF for ; Wed, 22 Feb 2023 22:42:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=vagrant@debian.org Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 9AD701ACCA; Wed, 22 Feb 2023 13:42:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1677102169; bh=7WbHQlbnEhn6Hn/X/IN6BoddGO5zfkN5ZHl0rrqv2Ko=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=N2/uHn/0wCKfWMtuCAM46zIjCA/hK+HHG/Qxy5qw+lHDp+ml+Hrj6ljCGEn4Ci/88 HJfc4EEpa+kjCpjN3OnluQw+H2RBcEijlhiDBPWVr6CCwpT64OJJ8FxqtCSJ7nRZIc ornmfENKB7NoVgQkq97VA/RqGfr+oq1u9sRlN75/3yxEtnPT0CU4gHzzsRLCecoyTT k1mQIsRePgFiElM3nU/Y/jKby+x2GW7VRWzGn78BWk2ptpWwmE27AMMC6B6QVzHKuS j7lTSI+KucstNbdS2IK7t6HV7gKg7jFvi96dvnSfjN+uMCsJeV49hzYG7UWt6ZkIFP o90vatvrQuqUg== From: Vagrant Cascadian To: Jonas Karlman , Simon Glass , Philipp Tomsich , Kever Yang Cc: Jagan Teki , YouMin Chen , u-boot@lists.denx.de, Jonas Karlman Subject: Re: [PATCH] rockchip: dts: rk3328: fix sdram params In-Reply-To: <20230210183002.114902-1-jonas@kwiboo.se> References: <20230210183002.114902-1-jonas@kwiboo.se> Date: Wed, 22 Feb 2023 13:42:44 -0800 Message-ID: <874jrdxtpn.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-02-10, Jonas Karlman wrote: > The rk3328 sdram driver read sdram parameters from the devicetree into a > struct rk3328_sdram_params using dev_read_u32_array. > > After commit 5ab30c3176bf ("ram: rockchip: Update ddr pctl regs for px30") > changed the size of struct ddr_pctl_regs, a member of struct > rk3328_sdram_params, U-Boot TPL can no longer initialize DRAM on RK3328. > > Add ten u32 to the sdram parameter array in devicetree to align with > this size change. This fixes DRAM initialization on RK3328. > > Fixes: 5ab30c3176bf ("ram: rockchip: Update ddr pctl regs for px30") > Signed-off-by: Jonas Karlman > Reviewed-by: Simon Glass > Reviewed-by: Kever Yang > Reviewed-by: Jagan Teki > Tested-by: Jagan Teki # roc-rk3328-cc Thanks! This allows booting the rock64-rk3328 with v2023.04-rc2, which otherwise just hangs after loading TPL (or SPL?). Tested-by: Vagrant Cascadian > --- > arch/arm/dts/rk3328-sdram-ddr3-666.dtsi | 10 ++++++++++ > arch/arm/dts/rk3328-sdram-ddr4-666.dtsi | 10 ++++++++++ > arch/arm/dts/rk3328-sdram-lpddr3-1600.dtsi | 10 ++++++++++ > arch/arm/dts/rk3328-sdram-lpddr3-666.dtsi | 10 ++++++++++ > 4 files changed, 40 insertions(+) > > diff --git a/arch/arm/dts/rk3328-sdram-ddr3-666.dtsi b/arch/arm/dts/rk332= 8-sdram-ddr3-666.dtsi > index 3e88ed443ba0..c5acfe4ac2a0 100644 > --- a/arch/arm/dts/rk3328-sdram-ddr3-666.dtsi > +++ b/arch/arm/dts/rk3328-sdram-ddr3-666.dtsi > @@ -92,6 +92,16 @@ > 0xffffffff > 0xffffffff > 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff >=20=20 > 0x00000004 > 0x0000000a > diff --git a/arch/arm/dts/rk3328-sdram-ddr4-666.dtsi b/arch/arm/dts/rk332= 8-sdram-ddr4-666.dtsi > index 0859649a6905..c5fa2903c5c1 100644 > --- a/arch/arm/dts/rk3328-sdram-ddr4-666.dtsi > +++ b/arch/arm/dts/rk3328-sdram-ddr4-666.dtsi > @@ -89,6 +89,16 @@ > 0xffffffff > 0xffffffff > 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff >=20=20 > 0x00000004 > 0x0000000c > diff --git a/arch/arm/dts/rk3328-sdram-lpddr3-1600.dtsi b/arch/arm/dts/rk= 3328-sdram-lpddr3-1600.dtsi > index d63c761a0283..07f27b2b7bab 100644 > --- a/arch/arm/dts/rk3328-sdram-lpddr3-1600.dtsi > +++ b/arch/arm/dts/rk3328-sdram-lpddr3-1600.dtsi > @@ -92,6 +92,16 @@ > 0xffffffff > 0xffffffff > 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff >=20=20 > 0x00000004 > 0x0000000b > diff --git a/arch/arm/dts/rk3328-sdram-lpddr3-666.dtsi b/arch/arm/dts/rk3= 328-sdram-lpddr3-666.dtsi > index df42bb29ce88..d53d3a0fdfb2 100644 > --- a/arch/arm/dts/rk3328-sdram-lpddr3-666.dtsi > +++ b/arch/arm/dts/rk3328-sdram-lpddr3-666.dtsi > @@ -92,6 +92,16 @@ > 0xffffffff > 0xffffffff > 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff > + 0xffffffff >=20=20 > 0x00000004 > 0x0000000b --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY/aMVQAKCRDcUY/If5cW quuKAP95mml8bOvO/f7tpUsTvvJCUMfW+nwa/GcJdvpJr3c1BAEAsC7gedSmjCnV zrH+0KkceilN3QgfmlD7eOEn1RiDeAs= =w01e -----END PGP SIGNATURE----- --=-=-=--