From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: u-boot@lists.denx.de
Subject: [patch 4/8] RFC: drivers/video/rockchip/rk_edp.c: Change clock rate
Date: Fri, 23 Oct 2020 11:01:33 +0200 [thread overview]
Message-ID: <874kml48pe.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <5f1c3be6-76df-bec4-a7dd-9a310c15910b@gmail.com> (Alper Nebi Yasak's message of "Thu, 22 Oct 2020 21:49:27 +0300")
Alper Nebi Yasak <alpernebiyasak@gmail.com> writes:
> On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote:
>> The current code is setting the clock rate to 192000000, but
>> due to the current device-tree configuration and linux code,
>> it should rather be 100000000.
>>
>
> This looks like it's ACLK_VOP to me. FYI, coreboot sets it to 192 MHz
> for rk3288 and 200 MHz for rk3399. But from what I can understand the
> U-Boot rk3399 clock driver just ignores this call and sets it to 198 MHz
> anyway while setting DCLK_VOP...
In a perfect world, the rate should not be hardcoded and everyone should
rely on devicetree. Again, fixing that is more for a different patchset
than rk3399 edp support imho.
If it makes things easier, I'll test my patchset on my PBP without this
change and possibly drop this patch.
Arnaud
next prev parent reply other threads:[~2020-10-23 9:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 18:36 [patch 0/8] RFC: Pinebook pro EDP support Arnaud Patard
2020-09-25 18:36 ` [patch 1/8] RFC: drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode Arnaud Patard
2020-09-28 2:44 ` Kever Yang
2020-09-25 18:36 ` [patch 2/8] RFC: drivers/video/rockchip/rk_edp.c: Add rk3399 support Arnaud Patard
2020-10-22 18:32 ` Alper Nebi Yasak
2020-10-23 8:49 ` Arnaud Patard
2020-10-23 10:14 ` Alper Nebi Yasak
2020-09-25 18:36 ` [patch 3/8] RFC: drivers/video/rockchip/rk_edp.c: Change interrupt polarity configuration Arnaud Patard
2020-10-22 18:39 ` Alper Nebi Yasak
2020-10-23 8:51 ` Arnaud Patard
2020-09-25 18:36 ` [patch 4/8] RFC: drivers/video/rockchip/rk_edp.c: Change clock rate Arnaud Patard
2020-10-22 18:49 ` Alper Nebi Yasak
2020-10-23 9:01 ` Arnaud Patard [this message]
2020-09-25 18:36 ` [patch 5/8] RFC: drivers/video/rockchip/rk_vop.c: Reserve efi fb memory Arnaud Patard
2020-09-25 18:37 ` [patch 6/8] RFC: rk3399-pinebook-pro-u-boot.dtsi: Enable edp Arnaud Patard
2020-09-25 18:37 ` [patch 7/8] RFC: configs/pinebook-pro-rk3399_defconfig: enable SYS_USB_EVENT_POLL_VIA_INT_QUEUE Arnaud Patard
2020-09-25 18:37 ` [patch 8/8] RFC: drivers/pwm/rk_pwm.c: Fix default polarity Arnaud Patard
2020-09-27 15:53 ` [patch 0/8] RFC: Pinebook pro EDP support Alper Nebi Yasak
2020-09-28 6:41 ` Arnaud Patard
2020-09-28 17:18 ` Alper Nebi Yasak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kml48pe.fsf@lechat.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox