From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
Date: Fri, 23 Oct 2020 11:01:33 +0200
Subject: [patch 4/8] RFC: drivers/video/rockchip/rk_edp.c: Change clock
 rate
In-Reply-To: <5f1c3be6-76df-bec4-a7dd-9a310c15910b@gmail.com> (Alper Nebi
 Yasak's message of "Thu, 22 Oct 2020 21:49:27 +0300")
References: <20200925183654.723338620@rtp-net.org>
 <20200925183856.497901419@rtp-net.org>
 <5f1c3be6-76df-bec4-a7dd-9a310c15910b@gmail.com>
Message-ID: <874kml48pe.fsf@lechat.rtp-net.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Alper Nebi Yasak <alpernebiyasak@gmail.com> writes:

> On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote:
>> The current code is setting the clock rate to 192000000, but
>> due to the current device-tree configuration and linux code,
>> it should rather be 100000000.
>> 
>
> This looks like it's ACLK_VOP to me. FYI, coreboot sets it to 192 MHz
> for rk3288 and 200 MHz for rk3399. But from what I can understand the
> U-Boot rk3399 clock driver just ignores this call and sets it to 198 MHz
> anyway while setting DCLK_VOP...

In a perfect world, the rate should not be hardcoded and everyone should
rely on devicetree. Again, fixing that is more for a different patchset
than rk3399 edp support imho.
If it makes things easier, I'll test my patchset on my PBP without this
change and possibly drop this patch.

Arnaud