Re: Regression in f_fastboot due to commit 6a92e9827650 ("usb: ci_udc: Check ci_ep->desc before use")

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Lothar,

On Wed, Jul 08, 2026 at 07:12, Lothar Waßmann <LW@KARO-electronics.de> wrote:

> Hi,
>
> commit 6a92e9827650 ("usb: ci_udc: Check ci_ep->desc before use") has
> the side effect that an empty buffer is being passed on to
> rx_handler_command() in drivers/usb/gadget/f_fastboot.c upon
> termination of a fastboot session which leads to a
> 'command  not recognized' error message being printed on the console.

Thank you for reporting this.

>
> Obviously without the commit the offending USB request had been silently
> dropped but is now delivered to the upper levels.
>
> I'm not sure what the correct fix would be.
> Should the fastboot driver ignore the empty command buffer or should
> the "Moreover, the patch gets rid of possible outstanding requests
> if the endpoint's state changes to disabled." part of the commit be
> reverted?

Petr, did you observe similar behaviour with the ums gadget?

>
>
> Lothar Waßmann