Re: [PATCH 02/13] cyclic: introduce u-boot/schedule.h

[Rasmus Villemoes <ravi@prevas.dk>]

Simon Glass <sjg@chromium.org> writes:

> On Thu, 3 Oct 2024 at 15:28, Rasmus Villemoes <ravi@prevas.dk> wrote:

>>  common/cyclic.c           |  1 +
>>  include/cyclic.h          | 12 +-----------
>>  include/u-boot/schedule.h | 24 ++++++++++++++++++++++++
>>  3 files changed, 26 insertions(+), 11 deletions(-)
>>  create mode 100644 include/u-boot/schedule.h
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> But could it just be include/schedule.h ?

I think the last paragraph in the commit message should answer that:

>> Testing of later patches that explicitly include <schedule.h> when
>> schedule() is used revealed a problem with host tool build on win32,
>> which apparently picked up a host <schedule.h>. To avoid that problem,
>> put the new header in include/u-boot/ and hence make the include
>> statements say <u-boot/schedule.h>.

So I tried that at first, and it worked fine for all my local builds,
but the CI told me it couldn't. I can try to find the old github PR
where I got the CI to tell me this (it's months ago I started doing
this), but I don't know if the azure logs still exist.

Rasmus