From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3723FC4332F for ; Tue, 1 Mar 2022 05:22:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C163883D03; Tue, 1 Mar 2022 06:22:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=tkos.co.il header.i=@tkos.co.il header.b="SErl2K8C"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A672A83D0D; Tue, 1 Mar 2022 06:22:28 +0100 (CET) Received: from mx.tkos.co.il (guitar.tcltek.co.il [84.110.109.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 97C7D83D03 for ; Tue, 1 Mar 2022 06:22:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=baruch@tkos.co.il Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id E0687440F99; Tue, 1 Mar 2022 07:21:42 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1646112103; bh=JlRnVDnB/hjNUNfbMwtDSVgGG5M/R16xKWVrJS7mqN8=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=SErl2K8CTOQWavMSIKSRN4kqZtldzYme3awSVJyYOfMYVo2tVUpXLPE7qyVsiSwJO 2lU1jsL1mVBgejp416xv5FmBG7+aa54zghEPghn1+mfCmntffDDU4Ymsd3OztoSV+t 0cWFnlcColWEq4ZamGoleAE6S+2TV+mSEKFVdPageiMuCwcdvQHgocd/vDxC73uVtE KoV4kHRV7Jm+TGaJ60poiK/2xnI6O0+baj8wYjLw8/e+dff8xHHnoSQuXmLbYORNTa JhkYp+lc5WIArGB3rWHnguGwfjXzBxgQviTo763t6SI37ctCc83vicyeQrCCPi1qRe 2R67epKORWWKw== References: <20220301005323.1786382-1-judge.packham@gmail.com> User-agent: mu4e 1.6.10; emacs 27.1 From: Baruch Siach To: Chris Packham Cc: u-boot@lists.denx.de, Chris Packham , Kostya Porotchkin , Marek =?utf-8?Q?Beh?= =?utf-8?Q?=C3=BAn?= , Moti Buskila , Nadav Haklai , Stefan Roese , Tom Rini Subject: Re: [PATCH] ARM: mvebu: x530: clearfog: Add ODT configuration Date: Tue, 01 Mar 2022 07:21:24 +0200 In-reply-to: <20220301005323.1786382-1-judge.packham@gmail.com> Message-ID: <875yoyxn5d.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Chris, On Tue, Mar 01 2022, Chris Packham wrote: > Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT > configuration") added the odt_config member to struct > mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This > means that any boards that configured either of clk_enable or ck_delay > needed to have their board topology updated. This affects the x530 and > clearfog boards. Other A38x boards don't touch any of the trailing > members of mv_ddr_topology_map so don't need updating. > > Fixes: 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") > Signed-off-by: Chris Packham Acked-by: Baruch Siach Thanks, baruch > --- > > board/alliedtelesis/x530/x530.c | 1 + > board/solidrun/clearfog/clearfog.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c > index 8b31045a0743..c0ec2afa3011 100644 > --- a/board/alliedtelesis/x530/x530.c > +++ b/board/alliedtelesis/x530/x530.c > @@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0, /* Clock enable mask */ > 160 /* Clock delay */ > }; > diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c > index c920cf8d6b50..03adb591d826 100644 > --- a/board/solidrun/clearfog/clearfog.c > +++ b/board/solidrun/clearfog/clearfog.c > @@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0,}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0x3, /* clock enable mask */ > }; -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -