public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] USB custodian repo updates
Date: Tue, 12 Jun 2007 10:24:44 +0200	[thread overview]
Message-ID: <87645t60mr.fsf@denx.de> (raw)
In-Reply-To: <200706091839.52114.matthias.fuchs@esd-electronics.com> (Matthias Fuchs's message of "Sat, 9 Jun 2007 18:39:51 +0200")

Hi Matthias,

Matthias Fuchs <matthias.fuchs@esd-electronics.com> writes:

> good work. I gave it a try on our PLU405 board (405EP) with a PCI attached 
> OHCI controller (ISP1561). I had to add a offset to the dma'ed addresses, 
> so that the USB controller can access the correct locations in RAM. 

Ok.

> CONFIG_PCI_CONFIG_HOST_BRIDGE must be defined and the pciconfighost variable
> must be set. After this, RAM is accessible at PCI address 0x8000000. I modified 
> drivers/usb_ohci.c to support this offset (CFG_USB_OHCI_DMA_BASE).
>
> I am not sure if there is a better way to get PCI OHCI working with a 405 CPU.
> U-Boot does not setup the PLB/PCI bridge so that the RAM is accessible at 
> PCI address 0.

And I think that we shouldn't force such a restriction. While your patch
doesn't actually augment readability ;-) i guess this is the price we
pay for supporting various controllers in one driver.

Could you resend your patch against the updated usb git repo and
including a Signed-off line? 

Best regards

Markus Klotzb?cher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

  reply	other threads:[~2007-06-12  8:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-06 10:49 [U-Boot-Users] USB custodian repo updates Markus Klotzbücher
2007-06-09 16:39 ` Matthias Fuchs
2007-06-12  8:24   ` Markus Klotzbücher [this message]
2007-08-07 20:48 ` [U-Boot-Users] USB PULL Request Markus Klotzbücher
2007-08-09 21:17   ` Wolfgang Denk
2007-08-10 17:06     ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87645t60mr.fsf@denx.de \
    --to=mk@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox