From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64724C433EF for ; Thu, 9 Sep 2021 15:08:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 754B96056B for ; Thu, 9 Sep 2021 15:08:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 754B96056B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 12EEF834CC; Thu, 9 Sep 2021 17:08:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Te+yidPg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3FC44834D1; Thu, 9 Sep 2021 17:08:03 +0200 (CEST) Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AA71B834BE for ; Thu, 9 Sep 2021 17:07:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-ot1-x32e.google.com with SMTP id l7-20020a0568302b0700b0051c0181deebso2848890otv.12 for ; Thu, 09 Sep 2021 08:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=S0gY+qVn6QK3DQCXIqWNTpbhXhDplT0lmxtBDs1Byxg=; b=Te+yidPg4MOz+Z5SdUpqN3zsmW7s6v4/v41xrJoOQdFZMvoRPU2IfNWwfyjugd+7FI ObQewmXmpxYelUSsLKGMYxE3X70jaS5/Veqt4KbWLvtm9Zi9Kfq1/wZLroEC+yoUO/Kz sGG1sMKySkgrAOxQpPucgXTO+ogk/0185wGE2V8m35ekn5HhD5TDJZnWJLPDmETidmCB 8Y4a0vdgQC175otKNLZR58yc+pXoIYr+BIWk4NylI7xWAJ/rLhSkThqlaQZA179EJY2x 45kTSHE0luy1rOCayWGspEn/coK5fSL7k3wCHd2h4tPFH5fkz1Yrj7Kks6uqwbVu9s8s E3cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S0gY+qVn6QK3DQCXIqWNTpbhXhDplT0lmxtBDs1Byxg=; b=KtjGVq9yvdPULMjzpPtaO0I0nrWD8WVFw4SqPw4Oa08gxR8AbBrtli2lp/Ogx89VRO Z7R7wl4Cu80SDlPTaWd7W+EY5WLiSLxvnPQPpcEjNGUyeuK5fx++/yAyRNXCY/HbvZJV N3QowjI6V5Vxmdck3Y7fFZocSW26dQyeDOIiz9xuq5UGfrxiLTs05j/UdXxS1fp9D+Ti fSqcDlhPLi+YeaXCHyNXHqrJn11tJEXJSc0kCO58LKQ5adGyQEbeI/B1AGv2XpxVVj11 hG1Kk8Ahs5mt+kRlbt2LAkLECjABmXNcWdn+AaykiwwVNKqTw724+OTmiFJ7PS/lJan6 vbPQ== X-Gm-Message-State: AOAM530Hof7ySOXNnmUw+F0hIGlfyp9MSzn5/unMYR6NlK87nf9966ay 8bGHwxGYeVcsPNem2VDGKsY8H4lzcxg= X-Google-Smtp-Source: ABdhPJzo61SNvEmTlwoAA48I9fJD/kkTXQgP9ZL23T/J3bat00kyYez51wCWgFKmxJ2tpji4vknOxQ== X-Received: by 2002:a9d:7052:: with SMTP id x18mr309965otj.78.1631200077991; Thu, 09 Sep 2021 08:07:57 -0700 (PDT) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id u27sm516238otj.6.2021.09.09.08.07.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 08:07:57 -0700 (PDT) Subject: Re: [PATCH] Kconfig: Drop duplicate 'select SHA512' instances To: u-boot@lists.denx.de References: <20210909150053.10795-1-trini@konsulko.com> From: "Alex G." Message-ID: <8768868e-8c1e-4f62-5603-31aabdf7709b@gmail.com> Date: Thu, 9 Sep 2021 10:07:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210909150053.10795-1-trini@konsulko.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/9/21 10:00 AM, Tom Rini wrote: > When dropping SHA512_ALGO in general, we didn't catch some cases where > an option was selecting both SHA512 and SHA512_ALGO and caused them to > select SHA512 twice. Kconfig doesn't complain, but this is still wrong > and should be corrected. > > Fixes: e60e44993120 ("lib: Drop SHA512_ALGO in lieu of SHA512") > Reported-by: Andreas Schwab > Signed-off-by: Tom Rini Reviewed-by: Alexandru Gagniuc > --- > lib/crypt/Kconfig | 1 - > lib/efi_loader/Kconfig | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/lib/crypt/Kconfig b/lib/crypt/Kconfig > index 6a5002964224..a59d5c7d1d54 100644 > --- a/lib/crypt/Kconfig > +++ b/lib/crypt/Kconfig > @@ -20,7 +20,6 @@ config CRYPT_PW_SHA256 > config CRYPT_PW_SHA512 > bool "Provide sha512crypt" > select SHA512 > - select SHA512 > help > Enables support for the sha512crypt password-hashing algorithm. > The prefix is "$6$". > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index 08463251cdf1..edd4ae29f163 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -323,7 +323,6 @@ config EFI_TCG2_PROTOCOL > depends on TPM_V2 > select SHA1 > select SHA256 > - select SHA512 > select SHA384 > select SHA512 > select HASH >