Re: [PATCH 05/10] usb: f_sdp: Update SDP driver to support PQC container

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Alice,

Thank you for the patch.

On Tue, Sep 23, 2025 at 19:11, "Alice Guo (OSS)" <alice.guo@oss.nxp.com> wrote:

> From: Ye Li <ye.li@nxp.com>
>
> Since PQC container has changed version to 0x2 in container header,
> update the header's check.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> Acked-by: Peng Fan <peng.fan@nxp.com>
> Reviewed-by: Jacky Bai <ping.bai@nxp.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>  drivers/usb/gadget/f_sdp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c
> index 647001d8dd0..f72e27028b7 100644
> --- a/drivers/usb/gadget/f_sdp.c
> +++ b/drivers/usb/gadget/f_sdp.c
> @@ -765,7 +765,7 @@ static ulong search_container_header(ulong p, int size)
>  
>  	for (i = 0; i < size; i += 4) {
>  		hdr = (u8 *)(p + i);
> -		if (*(hdr + 3) == 0x87 && *hdr == 0)
> +		if (*(hdr + 3) == 0x87 && (*hdr == 0 || *hdr == 2))
>  			if (*(hdr + 1) != 0 || *(hdr + 2) != 0)
>  				return p + i;
>  	}
>
> -- 
> 2.43.0