public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Marcel Ziswiler <marcel@ziswiler.com>, u-boot@lists.denx.de
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
	Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
	Nishanth Menon <nm@ti.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>
Subject: Re: [PATCH v1] include: configs: verdin-am62: drop unused sdram address
Date: Tue, 29 Aug 2023 09:43:55 +0200	[thread overview]
Message-ID: <877cpeb8ec.fsf@baylibre.com> (raw)
In-Reply-To: <20230828215037.482278-1-marcel@ziswiler.com>

Hi Marcel,

Thank you for following up this quickly on this.

On lun., août 28, 2023 at 23:50, Marcel Ziswiler <marcel@ziswiler.com> wrote:

> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Drop unused macro. This was copied straight from the AM62x EVM but while
> meant for a second region of DDR this is not even needed for the AM62x
> EVM configurations and has meanwhile also been dropped there.
>
> Note that on the Verdin AM62, we do auto-detect the amount of SDRAM.
>
> While at it also update the comment noting that CFG_SYS_SDRAM_SIZE is
> the maximum which is only used for such auto-detection.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

>
> ---
>
>  include/configs/verdin-am62.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/configs/verdin-am62.h b/include/configs/verdin-am62.h
> index 7990ea83102..e1a5f5ad44b 100644
> --- a/include/configs/verdin-am62.h
> +++ b/include/configs/verdin-am62.h
> @@ -13,8 +13,7 @@
>  
>  /* DDR Configuration */
>  #define CFG_SYS_SDRAM_BASE	0x80000000
> -#define CFG_SYS_SDRAM_BASE1	0x880000000
> -#define CFG_SYS_SDRAM_SIZE	SZ_2G /* Maximum supported size */
> +#define CFG_SYS_SDRAM_SIZE	SZ_2G /* Maximum supported size, auto-detection is used */
>  
>  #define MEM_LAYOUT_ENV_SETTINGS \
>  	"fdt_addr_r=0x90200000\0" \
> -- 
> 2.36.1

  reply	other threads:[~2023-08-29  7:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 21:50 [PATCH v1] include: configs: verdin-am62: drop unused sdram address Marcel Ziswiler
2023-08-29  7:43 ` Mattijs Korpershoek [this message]
2023-09-09 13:31 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cpeb8ec.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=emanuele.ghidoli@toradex.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marcel@ziswiler.com \
    --cc=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox