public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH v1] include: configs: verdin-am62: drop unused sdram address
@ 2023-08-28 21:50 Marcel Ziswiler
  2023-08-29  7:43 ` Mattijs Korpershoek
  2023-09-09 13:31 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Marcel Ziswiler @ 2023-08-28 21:50 UTC (permalink / raw)
  To: u-boot
  Cc: Mattijs Korpershoek, Francesco Dolcini, Emanuele Ghidoli,
	Nishanth Menon, Marcel Ziswiler

From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Drop unused macro. This was copied straight from the AM62x EVM but while
meant for a second region of DDR this is not even needed for the AM62x
EVM configurations and has meanwhile also been dropped there.

Note that on the Verdin AM62, we do auto-detect the amount of SDRAM.

While at it also update the comment noting that CFG_SYS_SDRAM_SIZE is
the maximum which is only used for such auto-detection.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

 include/configs/verdin-am62.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/configs/verdin-am62.h b/include/configs/verdin-am62.h
index 7990ea83102..e1a5f5ad44b 100644
--- a/include/configs/verdin-am62.h
+++ b/include/configs/verdin-am62.h
@@ -13,8 +13,7 @@
 
 /* DDR Configuration */
 #define CFG_SYS_SDRAM_BASE	0x80000000
-#define CFG_SYS_SDRAM_BASE1	0x880000000
-#define CFG_SYS_SDRAM_SIZE	SZ_2G /* Maximum supported size */
+#define CFG_SYS_SDRAM_SIZE	SZ_2G /* Maximum supported size, auto-detection is used */
 
 #define MEM_LAYOUT_ENV_SETTINGS \
 	"fdt_addr_r=0x90200000\0" \
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] include: configs: verdin-am62: drop unused sdram address
  2023-08-28 21:50 [PATCH v1] include: configs: verdin-am62: drop unused sdram address Marcel Ziswiler
@ 2023-08-29  7:43 ` Mattijs Korpershoek
  2023-09-09 13:31 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2023-08-29  7:43 UTC (permalink / raw)
  To: Marcel Ziswiler, u-boot
  Cc: Francesco Dolcini, Emanuele Ghidoli, Nishanth Menon,
	Marcel Ziswiler

Hi Marcel,

Thank you for following up this quickly on this.

On lun., août 28, 2023 at 23:50, Marcel Ziswiler <marcel@ziswiler.com> wrote:

> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Drop unused macro. This was copied straight from the AM62x EVM but while
> meant for a second region of DDR this is not even needed for the AM62x
> EVM configurations and has meanwhile also been dropped there.
>
> Note that on the Verdin AM62, we do auto-detect the amount of SDRAM.
>
> While at it also update the comment noting that CFG_SYS_SDRAM_SIZE is
> the maximum which is only used for such auto-detection.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

>
> ---
>
>  include/configs/verdin-am62.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/configs/verdin-am62.h b/include/configs/verdin-am62.h
> index 7990ea83102..e1a5f5ad44b 100644
> --- a/include/configs/verdin-am62.h
> +++ b/include/configs/verdin-am62.h
> @@ -13,8 +13,7 @@
>  
>  /* DDR Configuration */
>  #define CFG_SYS_SDRAM_BASE	0x80000000
> -#define CFG_SYS_SDRAM_BASE1	0x880000000
> -#define CFG_SYS_SDRAM_SIZE	SZ_2G /* Maximum supported size */
> +#define CFG_SYS_SDRAM_SIZE	SZ_2G /* Maximum supported size, auto-detection is used */
>  
>  #define MEM_LAYOUT_ENV_SETTINGS \
>  	"fdt_addr_r=0x90200000\0" \
> -- 
> 2.36.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] include: configs: verdin-am62: drop unused sdram address
  2023-08-28 21:50 [PATCH v1] include: configs: verdin-am62: drop unused sdram address Marcel Ziswiler
  2023-08-29  7:43 ` Mattijs Korpershoek
@ 2023-09-09 13:31 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2023-09-09 13:31 UTC (permalink / raw)
  To: Marcel Ziswiler
  Cc: u-boot, Mattijs Korpershoek, Francesco Dolcini, Emanuele Ghidoli,
	Nishanth Menon, Marcel Ziswiler

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Mon, Aug 28, 2023 at 11:50:37PM +0200, Marcel Ziswiler wrote:

> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Drop unused macro. This was copied straight from the AM62x EVM but while
> meant for a second region of DDR this is not even needed for the AM62x
> EVM configurations and has meanwhile also been dropped there.
> 
> Note that on the Verdin AM62, we do auto-detect the amount of SDRAM.
> 
> While at it also update the comment noting that CFG_SYS_SDRAM_SIZE is
> the maximum which is only used for such auto-detection.
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-09 13:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-28 21:50 [PATCH v1] include: configs: verdin-am62: drop unused sdram address Marcel Ziswiler
2023-08-29  7:43 ` Mattijs Korpershoek
2023-09-09 13:31 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox