public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Simon Glass <sjg@chromium.org>
Subject: Re: [v4 5/7] rockchip: Disable DISTRO_DEFAULTS for rk3399 boards
Date: Fri, 24 Mar 2023 16:48:57 -0700	[thread overview]
Message-ID: <877cv5vhg6.fsf@wireframe> (raw)
In-Reply-To: <20230324205816.2035181-6-trini@konsulko.com>

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On 2023-03-24, Tom Rini wrote:
> These board have moved to standard boot but the old 'distro_bootcmd'
> command is still active. Disable DISTRO_DEFAULTS to fix this.

I successfully tested the v4 series against v2023.04-rc4 on
rockpro64-rk3399 and pinebook-pro-rk3399, and for good measure
double-checked that it did not introduce regressions on rock64-rk3328,
because it readily available to test. :)

Looks good to me, thanks!

live well,
  vagrant

> Signed-off-by: Simon Glass <sjg@chromium.org>
> Tested-by: Vagrant Cascadian <vagrant@debian.org>
> ---
> Changes in v4:
> None.
> ---
>  arch/arm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index bd7fffcce0ba..4e7ebeaee87d 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1955,7 +1955,7 @@ config ARCH_ROCKCHIP
>  	imply ADC
>  	imply CMD_DM
>  	imply DEBUG_UART_BOARD_INIT
> -	imply DISTRO_DEFAULTS
> +	imply DISTRO_DEFAULTS if !ROCKCHIP_RK3399
>  	imply FAT_WRITE
>  	imply SARADC_ROCKCHIP
>  	imply SPL_SYSRESET
> -- 
> 2.34.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2023-03-24 23:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 20:58 [v4 0/7] Fix Rockchip RK3399 bootstd migration Tom Rini
2023-03-24 20:58 ` [v4 1/7] rockchip: Drop bootstage stash in TPL and SPL for rockpro64 Tom Rini
2023-03-24 20:58 ` [v4 2/7] Move DISTRO_DEFAULTS into boot/ Tom Rini
2023-03-24 20:58 ` [v4 3/7] lmb: Enable LMB if SYS_BOOT_RAMDISK_HIGH Tom Rini
2023-03-24 20:58 ` [v4 4/7] boot: Create a common BOOT_DEFAULTS for distro and bootstd Tom Rini
2023-03-24 20:58 ` [v4 5/7] rockchip: Disable DISTRO_DEFAULTS for rk3399 boards Tom Rini
2023-03-24 23:48   ` Vagrant Cascadian [this message]
2023-03-24 20:58 ` [v4 6/7] rockchip: Use BOOTSTD_DEFAULTS if not DISTRO_DEFAULTS Tom Rini
2023-03-24 20:58 ` [v4 7/7] rockchip: rk3399: Drop altbootcmd Tom Rini
2023-03-26 18:07   ` Jonas Karlman
2023-03-27  4:00 ` [v4 0/7] Fix Rockchip RK3399 bootstd migration Simon Glass
2023-03-27 15:42   ` Tom Rini
2023-03-27 17:50   ` Peter Robinson
2023-03-27 19:03     ` Simon Glass
2023-03-29 14:54     ` Tom Rini
2023-03-30  6:55       ` Peter Robinson
2023-03-30 20:13         ` Simon Glass
2023-03-31  8:39           ` Peter Robinson
2023-03-31 17:44             ` Tom Rini
2023-04-01  6:31             ` Simon Glass
2023-03-27 17:34 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cv5vhg6.fsf@wireframe \
    --to=vagrant@debian.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox