public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: Simon Glass <sjg@chromium.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Cc: huang lin <hl@rock-chips.com>,
	Jeffy Chen <jeffy.chen@rock-chips.com>,
	Simon Glass <sjg@chromium.org>,
	Kever Yang <kever.yang@rock-chips.com>,
	Tom Rini <trini@konsulko.com>, Akash Gajjar <akash@openedev.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64
Date: Wed, 22 Feb 2023 10:19:03 -0800	[thread overview]
Message-ID: <877cw9y354.fsf@contorta> (raw)
In-Reply-To: <875ybur3zm.fsf@contorta>

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

On 2023-02-21, Vagrant Cascadian wrote:
> On 2023-02-21, Simon Glass wrote:
>> This board has moved to standard boot but the old 'distro_bootcmd'
>> command is still active. Disable DISTRO_DEFAULTS to fix this.
>
> Works for booting rockpro64-rk3399, thanks!

I can also confirm that applying a very similar patch for
pinebook-pro-rk3399 works booting with bootstd.

Seems worth adding if there is a v2 of the patch series.

Alternately, rather than doing this on a board-by-board basis, is there
some way to disable CONFIG_DISTRO_DEFAULTS when a board is using
BOOTSTD?

live well,
  vagrant

>>  configs/rockpro64-rk3399_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
>> index 49614236819..fe2415c87c9 100644
>> --- a/configs/rockpro64-rk3399_defconfig
>> +++ b/configs/rockpro64-rk3399_defconfig
>> @@ -19,6 +19,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y
>>  CONFIG_SPL_SPI=y
>>  CONFIG_SYS_LOAD_ADDR=0x800800
>>  CONFIG_DEBUG_UART=y
>> +# CONFIG_DISTRO_DEFAULTS is not set
>>  CONFIG_BOOTSTAGE=y
>>  CONFIG_BOOTSTAGE_REPORT=y
>>  CONFIG_USE_PREBOOT=y
>> -- 
>> 2.39.2.637.g21b0678d19-goog

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2023-02-22 18:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 19:39 [PATCH 1/3] rockchip: Drop bootstage stash in TPL and SPL Simon Glass
2023-02-21 19:39 ` [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64 Simon Glass
2023-02-21 23:30   ` Vagrant Cascadian
2023-02-22 18:19     ` Vagrant Cascadian [this message]
2023-02-22 18:24       ` Tom Rini
2023-02-22 18:56         ` Jonas Karlman
2023-02-22 18:58           ` Simon Glass
2023-02-22 19:01             ` Tom Rini
2023-02-22 19:03               ` Simon Glass
2023-02-22 19:15                 ` Tom Rini
2023-03-16 11:01                   ` Peter Robinson
2023-03-16 18:17                     ` Tom Rini
2023-03-17  5:25                       ` Simon Glass
2023-02-21 19:39 ` [PATCH 3/3] bootstd: Enable BOOTSTD_DEFAULTS by default Simon Glass
2023-02-21 23:29   ` Vagrant Cascadian
2023-02-21 23:28 ` [PATCH 1/3] rockchip: Drop bootstage stash in TPL and SPL Vagrant Cascadian
2023-02-22 14:47 ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cw9y354.fsf@contorta \
    --to=vagrant@debian.org \
    --cc=akash@openedev.com \
    --cc=hl@rock-chips.com \
    --cc=jagan@amarulasolutions.com \
    --cc=jeffy.chen@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox