From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1558FC636D6 for ; Wed, 22 Feb 2023 18:19:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E454085B05; Wed, 22 Feb 2023 19:19:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=debian.org header.i=@debian.org header.b="dQNCmYmt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D126080AE2; Wed, 22 Feb 2023 19:19:16 +0100 (CET) Received: from cascadia.aikidev.net (cascadia.aikidev.net [IPv6:2600:3c01:e000:267:0:a171:de7:c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 062E385B0F for ; Wed, 22 Feb 2023 19:19:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=vagrant@debian.org Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 1A87A1AC60; Wed, 22 Feb 2023 10:19:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1677089948; bh=A0Cgrd7PXOlGX6HYRROH1vTtK5nMlmfE/8pTVI1oAy4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dQNCmYmtoGimhU7Z5LqUnOJsCVKnNoCxy3HrhbiXRuJWq35hUJYER0qs6zsJ6PIGS X+ZYyXt3X8stY4hNis3zaa4KdvBejFHkFNp8PwzlY+wvT84sALO2o3ZkBVYpEXZRRI RNd2NJQMTxAIgVWKPsjNSQcxQ55N/K3NZUka8ySULkSd+KZDhcGHG53C1udlmdDsQO qWEWA1xHu0uJdhyAyIcON4lNRbOsB4ea9nWjA2HOkg7TbxuyS8682POTS3bOUZbBXv +zvWyIVmHxC1tr7STn1C3jWjrgUjtNqVuxP/s+R/IgwpXG2IJ0ruw5P6RfhVub4CLZ hMUZW9f0qkHCg== From: Vagrant Cascadian To: Simon Glass , U-Boot Mailing List Cc: huang lin , Jeffy Chen , Simon Glass , Kever Yang , Tom Rini , Akash Gajjar , Jagan Teki Subject: Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64 In-Reply-To: <875ybur3zm.fsf@contorta> References: <20230221193920.3546499-1-sjg@chromium.org> <20230221193920.3546499-2-sjg@chromium.org> <875ybur3zm.fsf@contorta> Date: Wed, 22 Feb 2023 10:19:03 -0800 Message-ID: <877cw9y354.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-02-21, Vagrant Cascadian wrote: > On 2023-02-21, Simon Glass wrote: >> This board has moved to standard boot but the old 'distro_bootcmd' >> command is still active. Disable DISTRO_DEFAULTS to fix this. > > Works for booting rockpro64-rk3399, thanks! I can also confirm that applying a very similar patch for pinebook-pro-rk3399 works booting with bootstd. Seems worth adding if there is a v2 of the patch series. Alternately, rather than doing this on a board-by-board basis, is there some way to disable CONFIG_DISTRO_DEFAULTS when a board is using BOOTSTD? live well, vagrant >> configs/rockpro64-rk3399_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk33= 99_defconfig >> index 49614236819..fe2415c87c9 100644 >> --- a/configs/rockpro64-rk3399_defconfig >> +++ b/configs/rockpro64-rk3399_defconfig >> @@ -19,6 +19,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=3Dy >> CONFIG_SPL_SPI=3Dy >> CONFIG_SYS_LOAD_ADDR=3D0x800800 >> CONFIG_DEBUG_UART=3Dy >> +# CONFIG_DISTRO_DEFAULTS is not set >> CONFIG_BOOTSTAGE=3Dy >> CONFIG_BOOTSTAGE_REPORT=3Dy >> CONFIG_USE_PREBOOT=3Dy >> --=20 >> 2.39.2.637.g21b0678d19-goog --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY/ZclwAKCRDcUY/If5cW qhrQAQCjnwzcqkVamRFXLH8xsN9iurS9Gwq0M/0DtSpQzF0ZSQD8CyUNOB/1CazV 6tAQJaeD8VFXuPLlqF9YcI3Ru/GJmgE= =66/A -----END PGP SIGNATURE----- --=-=-=--