public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: u-boot@lists.denx.de
Subject: [PATCH v4 03/12] arm: mvebu: clearfog: use Pro name by default
Date: Mon, 27 Jan 2020 10:14:29 +0200	[thread overview]
Message-ID: <877e1d48pm.fsf@tarshish> (raw)
In-Reply-To: <20200126225009.7362-4-mrjoel@lixil.net>

Hi Joel,

On Mon, Jan 27 2020, Joel Johnson wrote:
> Make the board version printed indicate the Pro variant default.
> Also adjust static name casing to match what is expected for
> EEPROM product name to share string constants.
>
> ---
>
>
> Baruch - can you confirm expected/desired branding casing? The SolidRun
> website and prior to this commit uses "ClearFog", however the EEPROM
> checked values use "Clearfog", so I changed to match to be able to use
> the same string constant values for consistency.

I am fine with this change. The official name is "ClearFog", but you can
also find "Clearfog" in the documentation, for example:

  https://developer.solid-run.com/knowledge-base/a388-debian/

baruch

> Signed-off-by: Joel Johnson <mrjoel@lixil.net>
> ---
>  board/solidrun/clearfog/clearfog.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c
> index e268ef55a2..9b31902c70 100644
> --- a/board/solidrun/clearfog/clearfog.c
> +++ b/board/solidrun/clearfog/clearfog.c
> @@ -170,7 +170,7 @@ int board_init(void)
>  
>  int checkboard(void)
>  {
> -	char *board = "ClearFog";
> +	char *board = "Clearfog Pro";
>  
>  	cf_read_tlv_data();
>  	if (strlen(cf_tlv_data.tlv_product_name[0]) > 0)


-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2020-01-27  8:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-26 22:49 [PATCH v4 00/12] ClearFog Base static variant support Joel Johnson
2020-01-26 22:49 ` [PATCH v4 01/12] arm: mvebu: fix SerDes table alignment Joel Johnson
2020-01-26 22:49 ` [PATCH v4 02/12] arm: mvebu: solidrun: remove hardcoded DTS MAC address Joel Johnson
2020-01-26 22:50 ` [PATCH v4 03/12] arm: mvebu: clearfog: use Pro name by default Joel Johnson
2020-01-27  8:14   ` Baruch Siach [this message]
2020-01-26 22:50 ` [PATCH v4 04/12] arm: mvebu: clearfog: initial ClearFog Base variant Joel Johnson
2020-01-26 22:50 ` [PATCH v4 05/12] arm: mvebu: clearfog: Unify DT selection paths Joel Johnson
2020-01-26 22:50 ` [PATCH v4 06/12] arm: mvebu: clearfog: Add option for 2.5 Gbps SFP Joel Johnson
2020-01-27  5:29   ` Baruch Siach
2020-01-27  6:08     ` Joel Johnson
2020-01-27  7:20       ` Baruch Siach
2020-01-27 16:27         ` Joel Johnson
2020-01-27 16:57           ` Joel Johnson
2020-01-26 22:50 ` [PATCH v4 07/12] arm: mvebu: clearfog: add SPI offsets Joel Johnson
2020-01-26 22:50 ` [PATCH v4 08/12] arm: mvebu: enable working default boot support Joel Johnson
2020-01-26 22:50 ` [PATCH v4 09/12] arm: mvebu: clearfog: move ENV params to Kconfig Joel Johnson
2020-01-26 22:50 ` [PATCH v4 10/12] arm: mvebu: clearfog: don't always use SPL MMC Joel Johnson
2020-01-26 22:50 ` [PATCH v4 11/12] arm: mvebu: clearfog: Add SATA mode flags Joel Johnson
2020-01-26 22:50 ` [PATCH v4 12/12] arm: mvebu: clearfog: Use Pro DT by default Joel Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e1d48pm.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox