Re: [PATCH v3 4/6] cmd: bcb: introduce 'ab_dump' command to print BCB block content

Simon Glass
2024-10-09T01:59:08Z

On Tue, 8 Oct 2024 at 14:18, Dmitry Rokosov <ddrokosov@salutedevices.com> wrote:
>
> It's really helpful to have the ability to dump BCB block for debugging
> A/B logic on the board supported this partition schema.
>
> Command 'bcb ab_dump' prints all fields of bootloader_control struct
> including slot_metadata for all presented slots.
>
> Output example:
> =====
> > board# bcb ab_dump ubi 0#misc
> > Read 512 bytes from volume misc to 000000000bf07580
> > Read 512 bytes from volume misc to 000000000bf42f40
> > Bootloader Control: [misc]
> > Active Slot: _a
> > Magic Number: 0x42414342
> > Version: 1
> > Number of Slots: 2
> > Recovery Tries Remaining: 0
> > CRC: 0x2c8b50bc (Valid)
> >
> > Slot[0] Metadata:
> > - Priority: 15
> > - Tries Remaining: 0
> > - Successful Boot: 1
> > - Verity Corrupted: 0
> >
> > Slot[1] Metadata:
> > - Priority: 14
> > - Tries Remaining: 7
> > - Successful Boot: 0
> > - Verity Corrupted: 0
> ====
>
> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
> ---
> boot/android_ab.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> cmd/bcb.c | 35 +++++++++++++++++++++++++++
> include/android_ab.h | 10 ++++++++
> 3 files changed, 113 insertions(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Can you also update the test?