From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Dmitry Rokosov <ddrokosov@salutedevices.com>,
igor.opaniuk@gmail.com, sjg@chromium.org,
semen.protsenko@linaro.org, trini@konsulko.com,
colin.mcallister@garmin.com, 4.shket@gmail.com,
avromanov@salutedevices.com
Cc: u-boot@lists.denx.de, kernel@salutedevices.com,
rockosov@gmail.com, Dmitry Rokosov <ddrokosov@salutedevices.com>
Subject: Re: [PATCH v2 4/6] cmd: bcb: introduce 'ab_dump' command to print BCB block content
Date: Mon, 30 Sep 2024 17:52:27 +0200 [thread overview]
Message-ID: <878qv9m950.fsf@baylibre.com> (raw)
In-Reply-To: <20240911214945.15873-5-ddrokosov@salutedevices.com>
Hi Dmitry,
Thank you for the patch.
On jeu., sept. 12, 2024 at 00:49, Dmitry Rokosov <ddrokosov@salutedevices.com> wrote:
> It's really helpful to have the ability to dump BCB block for debugging
> A/B logic on the board supported this partition schema.
>
> Command 'bcb ab_dump' prints all fields of bootloader_control struct
> including slot_metadata for all presented slots.
>
> Output example:
> =====
>> board# bcb ab_dump ubi 0#misc
>> Read 512 bytes from volume misc to 000000000bf07580
>> Read 512 bytes from volume misc to 000000000bf42f40
>> Bootloader Control: [misc]
>> Active Slot: _a
>> Magic Number: 0x42414342
>> Version: 1
>> Number of Slots: 2
>> Recovery Tries Remaining: 0
>> CRC: 0x2c8b50bc (Valid)
>>
>> Slot[0] Metadata:
>> - Priority: 15
>> - Tries Remaining: 0
>> - Successful Boot: 1
>> - Verity Corrupted: 0
>>
>> Slot[1] Metadata:
>> - Priority: 14
>> - Tries Remaining: 7
>> - Successful Boot: 0
>> - Verity Corrupted: 0
> ====
>
> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> boot/android_ab.c | 68 ++++++++++++++++++++++++++++++++++++++++++++
> cmd/bcb.c | 35 +++++++++++++++++++++++
> include/android_ab.h | 10 +++++++
> 3 files changed, 113 insertions(+)
>
next prev parent reply other threads:[~2024-09-30 15:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 21:49 [PATCH v2 0/6] android_ab: introduce bcb ab_dump command and provide several bcb fixes Dmitry Rokosov
2024-09-11 21:49 ` [PATCH v2 1/6] include/android_ab: move ab_select_slot() documentation to @ notation Dmitry Rokosov
2024-09-12 1:02 ` Simon Glass
2024-09-30 7:58 ` Mattijs Korpershoek
2024-09-11 21:49 ` [PATCH v2 2/6] treewide: bcb: move ab_select command to bcb subcommands Dmitry Rokosov
2024-09-12 1:00 ` Simon Glass
2024-09-30 11:24 ` Mattijs Korpershoek
2024-10-08 12:07 ` Dmitry Rokosov
2024-09-11 21:49 ` [PATCH v2 3/6] cmd: bcb: change strcmp() usage style in the do_bcb_ab_select() Dmitry Rokosov
2024-09-12 1:00 ` Simon Glass
2024-09-30 15:48 ` Mattijs Korpershoek
2024-09-11 21:49 ` [PATCH v2 4/6] cmd: bcb: introduce 'ab_dump' command to print BCB block content Dmitry Rokosov
2024-09-12 1:00 ` Simon Glass
2024-09-30 15:52 ` Mattijs Korpershoek [this message]
2024-09-11 21:49 ` [PATCH v2 5/6] common: android_ab: fix slot suffix for abc block Dmitry Rokosov
2024-09-11 21:57 ` Dmitry Rokosov
2024-09-11 21:49 ` [PATCH v2 6/6] test/py: introduce test for ab_dump command Dmitry Rokosov
2024-09-12 1:01 ` Simon Glass
2024-09-12 7:10 ` [PATCH v2 0/6] android_ab: introduce bcb ab_dump command and provide several bcb fixes Dmitry Rokosov
2024-09-12 17:45 ` Tom Rini
2024-09-13 8:37 ` Dmitry Rokosov
2024-09-13 16:27 ` Dmitry Rokosov
2024-09-13 20:04 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qv9m950.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=4.shket@gmail.com \
--cc=avromanov@salutedevices.com \
--cc=colin.mcallister@garmin.com \
--cc=ddrokosov@salutedevices.com \
--cc=igor.opaniuk@gmail.com \
--cc=kernel@salutedevices.com \
--cc=rockosov@gmail.com \
--cc=semen.protsenko@linaro.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox