* [PATCH v2] usb: ehci-mx6: Add i.MX93 support
@ 2024-02-19 17:05 Mathieu Othacehe
2024-02-19 17:26 ` Fabio Estevam
2024-02-20 10:47 ` Marek Vasut
0 siblings, 2 replies; 4+ messages in thread
From: Mathieu Othacehe @ 2024-02-19 17:05 UTC (permalink / raw)
To: Tom Rini, Marek Vasut, Peng Fan, Shiji Yang, Ye Li,
Sébastien Szymanski, Fabio Estevam, Simon Glass,
Mathieu Othacehe
Cc: u-boot, Mathieu Othacehe
i.MX93 uses the same USB IP as i.MX8MM. It can then reuse the ehci-mx6
driver.
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
---
drivers/usb/host/Kconfig | 6 +++---
drivers/usb/host/ehci-mx6.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 0dd5736433c..f96027d7bd2 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -210,10 +210,10 @@ config USB_EHCI_MX6
config USB_EHCI_MX7
bool "Support for i.MX7 on-chip EHCI USB controller"
- depends on ARCH_MX7 || IMX8M
+ depends on ARCH_MX7 || IMX8M || IMX93
select EHCI_HCD_INIT_AFTER_RESET if ARCH_MX7
- select PHY if IMX8M
- select NOP_PHY if IMX8M
+ select PHY if IMX8M || IMX93
+ select NOP_PHY if IMX8M || IMX93
default y
---help---
Enables support for the on-chip EHCI controller on i.MX7 SoCs.
diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
index a9ed5e7a0d5..a35fcca43a2 100644
--- a/drivers/usb/host/ehci-mx6.c
+++ b/drivers/usb/host/ehci-mx6.c
@@ -538,7 +538,7 @@ static int ehci_usb_phy_mode(struct udevice *dev)
plat->init_type = USB_INIT_DEVICE;
else
plat->init_type = USB_INIT_HOST;
- } else if (is_mx7() || is_imx8mm() || is_imx8mn()) {
+ } else if (is_mx7() || is_imx8mm() || is_imx8mn() || is_imx93()) {
phy_status = (void __iomem *)(addr +
USBNC_PHY_STATUS_OFFSET);
val = readl(phy_status);
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: ehci-mx6: Add i.MX93 support
2024-02-19 17:05 [PATCH v2] usb: ehci-mx6: Add i.MX93 support Mathieu Othacehe
@ 2024-02-19 17:26 ` Fabio Estevam
2024-02-19 17:30 ` Mathieu Othacehe
2024-02-20 10:47 ` Marek Vasut
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2024-02-19 17:26 UTC (permalink / raw)
To: Mathieu Othacehe
Cc: Tom Rini, Marek Vasut, Peng Fan, Shiji Yang, Ye Li,
Sébastien Szymanski, Simon Glass, Mathieu Othacehe, u-boot
On Mon, Feb 19, 2024 at 2:05 PM Mathieu Othacehe <othacehe@gnu.org> wrote:
>
> i.MX93 uses the same USB IP as i.MX8MM. It can then reuse the ehci-mx6
> driver.
>
> Reviewed-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
I assume you will add USB support to some i.MX93 boards later.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: ehci-mx6: Add i.MX93 support
2024-02-19 17:26 ` Fabio Estevam
@ 2024-02-19 17:30 ` Mathieu Othacehe
0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Othacehe @ 2024-02-19 17:30 UTC (permalink / raw)
To: Fabio Estevam
Cc: Tom Rini, Marek Vasut, Peng Fan, Shiji Yang, Ye Li,
Sébastien Szymanski, Simon Glass, u-boot
Hello Fabio,
Thanks for having a look.
> I assume you will add USB support to some i.MX93 boards later.
Yes that's the plan for the boards that I own: imx93_var_som and
imx93-phyboard-segin :)
Mathieu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: ehci-mx6: Add i.MX93 support
2024-02-19 17:05 [PATCH v2] usb: ehci-mx6: Add i.MX93 support Mathieu Othacehe
2024-02-19 17:26 ` Fabio Estevam
@ 2024-02-20 10:47 ` Marek Vasut
1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2024-02-20 10:47 UTC (permalink / raw)
To: Mathieu Othacehe, Tom Rini, Peng Fan, Shiji Yang, Ye Li,
Sébastien Szymanski, Fabio Estevam, Simon Glass,
Mathieu Othacehe
Cc: u-boot
On 2/19/24 18:05, Mathieu Othacehe wrote:
> i.MX93 uses the same USB IP as i.MX8MM. It can then reuse the ehci-mx6
> driver.
>
> Reviewed-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
> ---
> drivers/usb/host/Kconfig | 6 +++---
> drivers/usb/host/ehci-mx6.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 0dd5736433c..f96027d7bd2 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -210,10 +210,10 @@ config USB_EHCI_MX6
>
> config USB_EHCI_MX7
> bool "Support for i.MX7 on-chip EHCI USB controller"
> - depends on ARCH_MX7 || IMX8M
> + depends on ARCH_MX7 || IMX8M || IMX93
> select EHCI_HCD_INIT_AFTER_RESET if ARCH_MX7
> - select PHY if IMX8M
> - select NOP_PHY if IMX8M
> + select PHY if IMX8M || IMX93
> + select NOP_PHY if IMX8M || IMX93
> default y
> ---help---
> Enables support for the on-chip EHCI controller on i.MX7 SoCs.
> diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
> index a9ed5e7a0d5..a35fcca43a2 100644
> --- a/drivers/usb/host/ehci-mx6.c
> +++ b/drivers/usb/host/ehci-mx6.c
> @@ -538,7 +538,7 @@ static int ehci_usb_phy_mode(struct udevice *dev)
> plat->init_type = USB_INIT_DEVICE;
> else
> plat->init_type = USB_INIT_HOST;
> - } else if (is_mx7() || is_imx8mm() || is_imx8mn()) {
> + } else if (is_mx7() || is_imx8mm() || is_imx8mn() || is_imx93()) {
> phy_status = (void __iomem *)(addr +
> USBNC_PHY_STATUS_OFFSET);
> val = readl(phy_status);
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-20 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-19 17:05 [PATCH v2] usb: ehci-mx6: Add i.MX93 support Mathieu Othacehe
2024-02-19 17:26 ` Fabio Estevam
2024-02-19 17:30 ` Mathieu Othacehe
2024-02-20 10:47 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox