From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE098C0015E for ; Fri, 28 Jul 2023 07:56:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CF72686887; Fri, 28 Jul 2023 09:56:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20221208.gappssmtp.com header.i=@baylibre-com.20221208.gappssmtp.com header.b="5a0yxS02"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 38C9686886; Fri, 28 Jul 2023 09:56:13 +0200 (CEST) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 916AC86872 for ; Fri, 28 Jul 2023 09:56:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fbc5d5742eso20310205e9.3 for ; Fri, 28 Jul 2023 00:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1690530970; x=1691135770; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=l80s3F8ETU52id3mdeZWYyz00Sxt3RdTPDJ+dAyi2p0=; b=5a0yxS02smusadthyLcjLydonkDa0T6INlehzk2ZS5Cw1jB1siY1ZrOvJSoNGsqd52 cDjnzoeemFRg/ede0Ca6WZWLt8mrRua/70RpMiHzfKYT0LCTlyIHSQ3NTNkNgSrfQeyQ A6qE3DPmmP9J+gMy5v7CfjXG5RVK6M5QwU3rkxubx637LV9tthsrMgvw/pvH/Qsxp889 PpYIR/azbHT3Jlqab1ljjk6fEYnd725l2c0+I08ZXbIbglUtLsJv+Jv6ZeVmlNurybSw n0OWA8BmqD17x7iELqkVY6BB8vig+Uqc5PD+Tu5SoFIY1odsBl6+29Xeh1M9b4Pq+Oik 23FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690530970; x=1691135770; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l80s3F8ETU52id3mdeZWYyz00Sxt3RdTPDJ+dAyi2p0=; b=jYL3u3z0+YboT/Xe04oKfhQYZj7dtHLLYMVaAtiIAhpAYRwL1NiXCCWwt3rurSQ7mJ DgS+CvlimS7B/1RI5qVM1jrGKci0QM1Izmg1INH5duMZ7fMTPK8I9d24lf899qqQa3Ap Ri89JvgO9Be5+k+/dGNRCcUe6gKNkvM25dJWWZuKEOKKeQ8cfpRZUH0Jj2NjJTLvEFLS txDl8CVyC7ipOEg0APPUGSlh79LYtSb832m2vLnEKLfgU6MKrdY6g/tLpmWk5VCT998c uDufIa3ibTr7kJIyllYbIrj+26wh0azGZBBgcKth5PojN2FoKvdYt98QQh2qFUNxZlmz iPpw== X-Gm-Message-State: ABy/qLbTlCWkixyV2fhb2xP5ClL9U1DLTBoFeHNVuFqOYAXwlEGDPGSD 4utqbY/wxu2kwkv6uSSxIgxwTw== X-Google-Smtp-Source: APBJJlE4iPjCyD2V3P3doKsGeS/cPuU75XcB846vqdwr7xzkmaeX8WIXYkCzvHJQUWbGLU0GWayjpw== X-Received: by 2002:a7b:cbd6:0:b0:3fb:ef86:e2e with SMTP id n22-20020a7bcbd6000000b003fbef860e2emr1048548wmi.19.1690530970003; Fri, 28 Jul 2023 00:56:10 -0700 (PDT) Received: from localhost ([2a01:cb19:85e6:1900:2bf7:7388:731d:c4e1]) by smtp.gmail.com with ESMTPSA id o10-20020a1c750a000000b003fba92fad35sm6377773wmc.26.2023.07.28.00.56.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 00:56:09 -0700 (PDT) From: Mattijs Korpershoek To: Simon Glass , U-Boot Mailing List Cc: Bin Meng , Simon Glass Subject: Re: [PATCH 4/8] bootstd: Correct creating of bootdev sibling In-Reply-To: <20230728023755.680278-5-sjg@chromium.org> References: <20230728023755.680278-1-sjg@chromium.org> <20230728023755.680278-5-sjg@chromium.org> Date: Fri, 28 Jul 2023 09:56:08 +0200 Message-ID: <878rb04gh3.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On jeu., juil. 27, 2023 at 20:37, Simon Glass wrote: > Use the correct function here, since there may be multiple IDE devices > available. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > drivers/block/ide.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/ide.c b/drivers/block/ide.c > index 89201dd4d229..c698f9cbd558 100644 > --- a/drivers/block/ide.c > +++ b/drivers/block/ide.c > @@ -1059,9 +1059,9 @@ static int ide_probe(struct udevice *udev) > desc->lba48 = pdesc.lba48; > desc->type = pdesc.type; > > - ret = bootdev_setup_for_dev(udev, "ide_bootdev"); > + ret = bootdev_setup_for_sibling_blk(blk, "ide_bootdev"); > if (ret) > - return log_msg_ret("bootdev", ret); > + return log_msg_ret("bd", ret); > } > > return 0; > -- > 2.41.0.487.g6d72f3e995-goog