* [PATCH] rockchip: Pinebook Pro: Fix emmc default configuration
@ 2023-05-01 7:43 Wolfgang Zarre
2023-05-01 19:28 ` Peter Robinson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Wolfgang Zarre @ 2023-05-01 7:43 UTC (permalink / raw)
To: u-boot, Simon Glass, Kever Yang, Philipp Tomsich
Cc: Wolfgang Zarre, Peter Robinson
If u-boot is installed on the internal emmc, then this will
allow to boot without failure.
Signed-off-by: Wolfgang Zarre <lxdev12@zirdeon.com>
---
configs/pinebook-pro-rk3399_defconfig | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig
index dff4695e37..58a8b91aa6 100644
--- a/configs/pinebook-pro-rk3399_defconfig
+++ b/configs/pinebook-pro-rk3399_defconfig
@@ -6,6 +6,7 @@ CONFIG_TEXT_BASE=0x00200000
CONFIG_NR_DRAM_BANKS=1
CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
+CONFIG_SF_DEFAULT_SPEED=20000000
CONFIG_ENV_SIZE=0x8000
CONFIG_ENV_OFFSET=0x3F8000
CONFIG_DEFAULT_DEVICE_TREE="rk3399-pinebook-pro"
@@ -18,6 +19,7 @@ CONFIG_DEBUG_UART_CLOCK=24000000
CONFIG_SPL_SPI_FLASH_SUPPORT=y
CONFIG_SPL_SPI=y
CONFIG_SYS_LOAD_ADDR=0x800800
+CONFIG_PCI=y
CONFIG_DEBUG_UART=y
CONFIG_BOOTDELAY=3
CONFIG_USE_PREBOOT=y
@@ -57,17 +59,23 @@ CONFIG_LED=y
CONFIG_LED_GPIO=y
CONFIG_MISC=y
CONFIG_ROCKCHIP_EFUSE=y
+CONFIG_MMC_IO_VOLTAGE=y
+CONFIG_SPL_MMC_IO_VOLTAGE=y
+CONFIG_MMC_UHS_SUPPORT=y
+CONFIG_SPL_MMC_UHS_SUPPORT=y
+CONFIG_MMC_HS400_ES_SUPPORT=y
+CONFIG_SPL_MMC_HS400_ES_SUPPORT=y
+CONFIG_MMC_HS400_SUPPORT=y
+CONFIG_SPL_MMC_HS400_SUPPORT=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
CONFIG_MMC_SDHCI_SDMA=y
CONFIG_MMC_SDHCI_ROCKCHIP=y
CONFIG_SF_DEFAULT_BUS=1
-CONFIG_SF_DEFAULT_SPEED=20000000
CONFIG_SPI_FLASH_GIGADEVICE=y
CONFIG_SPI_FLASH_WINBOND=y
CONFIG_NVME_PCI=y
-CONFIG_PCI=y
CONFIG_PHY_ROCKCHIP_INNO_USB2=y
CONFIG_PHY_ROCKCHIP_TYPEC=y
CONFIG_DM_PMIC_FAN53555=y
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] rockchip: Pinebook Pro: Fix emmc default configuration
2023-05-01 7:43 [PATCH] rockchip: Pinebook Pro: Fix emmc default configuration Wolfgang Zarre
@ 2023-05-01 19:28 ` Peter Robinson
2023-05-02 10:20 ` Wolf
2023-05-18 0:57 ` Kever Yang
2023-06-20 19:37 ` Vagrant Cascadian
2 siblings, 1 reply; 5+ messages in thread
From: Peter Robinson @ 2023-05-01 19:28 UTC (permalink / raw)
To: Wolfgang Zarre; +Cc: u-boot, Simon Glass, Kever Yang, Philipp Tomsich
On Mon, May 1, 2023 at 8:43 AM Wolfgang Zarre <lxdev12@zirdeon.com> wrote:
>
> If u-boot is installed on the internal emmc, then this will
> allow to boot without failure.
>
> Signed-off-by: Wolfgang Zarre <lxdev12@zirdeon.com>
> ---
>
> configs/pinebook-pro-rk3399_defconfig | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig
> index dff4695e37..58a8b91aa6 100644
> --- a/configs/pinebook-pro-rk3399_defconfig
> +++ b/configs/pinebook-pro-rk3399_defconfig
> @@ -6,6 +6,7 @@ CONFIG_TEXT_BASE=0x00200000
> CONFIG_NR_DRAM_BANKS=1
> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
> +CONFIG_SF_DEFAULT_SPEED=20000000
Why move this?
> CONFIG_ENV_SIZE=0x8000
> CONFIG_ENV_OFFSET=0x3F8000
> CONFIG_DEFAULT_DEVICE_TREE="rk3399-pinebook-pro"
> @@ -18,6 +19,7 @@ CONFIG_DEBUG_UART_CLOCK=24000000
> CONFIG_SPL_SPI_FLASH_SUPPORT=y
> CONFIG_SPL_SPI=y
> CONFIG_SYS_LOAD_ADDR=0x800800
> +CONFIG_PCI=y
Or this?
> CONFIG_DEBUG_UART=y
> CONFIG_BOOTDELAY=3
> CONFIG_USE_PREBOOT=y
> @@ -57,17 +59,23 @@ CONFIG_LED=y
> CONFIG_LED_GPIO=y
> CONFIG_MISC=y
> CONFIG_ROCKCHIP_EFUSE=y
> +CONFIG_MMC_IO_VOLTAGE=y
> +CONFIG_SPL_MMC_IO_VOLTAGE=y
> +CONFIG_MMC_UHS_SUPPORT=y
> +CONFIG_SPL_MMC_UHS_SUPPORT=y
> +CONFIG_MMC_HS400_ES_SUPPORT=y
> +CONFIG_SPL_MMC_HS400_ES_SUPPORT=y
> +CONFIG_MMC_HS400_SUPPORT=y
> +CONFIG_SPL_MMC_HS400_SUPPORT=y
Can you provide more details why these fix it?
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_SDMA=y
> CONFIG_MMC_SDHCI_ROCKCHIP=y
> CONFIG_SF_DEFAULT_BUS=1
> -CONFIG_SF_DEFAULT_SPEED=20000000
> CONFIG_SPI_FLASH_GIGADEVICE=y
> CONFIG_SPI_FLASH_WINBOND=y
> CONFIG_NVME_PCI=y
> -CONFIG_PCI=y
> CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> CONFIG_PHY_ROCKCHIP_TYPEC=y
> CONFIG_DM_PMIC_FAN53555=y
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rockchip: Pinebook Pro: Fix emmc default configuration
2023-05-01 19:28 ` Peter Robinson
@ 2023-05-02 10:20 ` Wolf
0 siblings, 0 replies; 5+ messages in thread
From: Wolf @ 2023-05-02 10:20 UTC (permalink / raw)
To: Peter Robinson; +Cc: u-boot, Simon Glass, Kever Yang, Philipp Tomsich
On 01/05/2023 21:28, Peter Robinson wrote:
> On Mon, May 1, 2023 at 8:43 AM Wolfgang Zarre <lxdev12@zirdeon.com> wrote:
>>
>> If u-boot is installed on the internal emmc, then this will
>> allow to boot without failure.
>>
>> Signed-off-by: Wolfgang Zarre <lxdev12@zirdeon.com>
>> ---
>>
>> configs/pinebook-pro-rk3399_defconfig | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig
>> index dff4695e37..58a8b91aa6 100644
>> --- a/configs/pinebook-pro-rk3399_defconfig
>> +++ b/configs/pinebook-pro-rk3399_defconfig
>> @@ -6,6 +6,7 @@ CONFIG_TEXT_BASE=0x00200000
>> CONFIG_NR_DRAM_BANKS=1
>> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
>> +CONFIG_SF_DEFAULT_SPEED=20000000
>
> Why move this?
>
This was not intentional but a result of the procedure
(on top of fe3a77cb157a6210d8036845f5f80ea67c183563):
make distclean
make pinebook-pro-rk3399_defconfig
make menuconfig
make savedefconfig
cp defconfig configs/pinebook-pro-rk3399_defconfig
>> CONFIG_ENV_SIZE=0x8000
>> CONFIG_ENV_OFFSET=0x3F8000
>> CONFIG_DEFAULT_DEVICE_TREE="rk3399-pinebook-pro"
>> @@ -18,6 +19,7 @@ CONFIG_DEBUG_UART_CLOCK=24000000
>> CONFIG_SPL_SPI_FLASH_SUPPORT=y
>> CONFIG_SPL_SPI=y
>> CONFIG_SYS_LOAD_ADDR=0x800800
>> +CONFIG_PCI=y
>
> Or this?
>
Same as above.
>> CONFIG_DEBUG_UART=y
>> CONFIG_BOOTDELAY=3
>> CONFIG_USE_PREBOOT=y
>> @@ -57,17 +59,23 @@ CONFIG_LED=y
>> CONFIG_LED_GPIO=y
>> CONFIG_MISC=y
>> CONFIG_ROCKCHIP_EFUSE=y
>> +CONFIG_MMC_IO_VOLTAGE=y
>> +CONFIG_SPL_MMC_IO_VOLTAGE=y
>> +CONFIG_MMC_UHS_SUPPORT=y
>> +CONFIG_SPL_MMC_UHS_SUPPORT=y
>> +CONFIG_MMC_HS400_ES_SUPPORT=y
>> +CONFIG_SPL_MMC_HS400_ES_SUPPORT=y
>> +CONFIG_MMC_HS400_SUPPORT=y
>> +CONFIG_SPL_MMC_HS400_SUPPORT=y
>
> Can you provide more details why these fix it?
>
Sure, if you install u-boot on the internal emmc without these configuration:
dd if=idbloader.img of=/dev/mmcblk2 seek=64 conv=notrunc
dd if=u-boot.itb of=/dev/mmcblk2 seek=16384 conv=notrunc
and the external microSD is removed and SPI not flashed, the you will find
following output:
U-Boot TPL 2023.04-00622-g698c2bd364 (Apr 05 2023 - 09:02:13)
lpddr4_set_rate: change freq to 400MHz 0, 1
Channel 0: LPDDR4, 400MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
Channel 1: LPDDR4, 400MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
256B stride
lpddr4_set_rate: change freq to 800MHz 1, 0
Trying to boot from BOOTROM
Returning to boot ROM...
U-Boot SPL 2023.04-00622-g698c2bd364 (Apr 05 2023 - 09:02:13 +0200)
Trying to boot from MMC1
mmc_load_image_raw_sector: mmc block read error
Trying to boot from MMC1
mmc fail to send stop cmd
mmc_load_image_raw_sector: mmc block read error
Trying to boot from SPI
Trying to boot from MMC2
Card did not respond to voltage select! : -110
spl: mmc init failed with error: -95
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###
With the configuration above the pinebook pro boots as expected from the internal emmc.
I may also mention that I got my pinebook pro delivered with a SDINADF4-128GB iNAND 7232 emmc
but standard seems to be (or was ?) a SDINBDA4-64G iNAND 7550 emmc, however, both are having
a HS400 interface and enhanced strobe.
>> CONFIG_MMC_DW=y
>> CONFIG_MMC_DW_ROCKCHIP=y
>> CONFIG_MMC_SDHCI=y
>> CONFIG_MMC_SDHCI_SDMA=y
>> CONFIG_MMC_SDHCI_ROCKCHIP=y
>> CONFIG_SF_DEFAULT_BUS=1
>> -CONFIG_SF_DEFAULT_SPEED=20000000
>> CONFIG_SPI_FLASH_GIGADEVICE=y
>> CONFIG_SPI_FLASH_WINBOND=y
>> CONFIG_NVME_PCI=y
>> -CONFIG_PCI=y
>> CONFIG_PHY_ROCKCHIP_INNO_USB2=y
>> CONFIG_PHY_ROCKCHIP_TYPEC=y
>> CONFIG_DM_PMIC_FAN53555=y
>> --
>> 2.39.2
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rockchip: Pinebook Pro: Fix emmc default configuration
2023-05-01 7:43 [PATCH] rockchip: Pinebook Pro: Fix emmc default configuration Wolfgang Zarre
2023-05-01 19:28 ` Peter Robinson
@ 2023-05-18 0:57 ` Kever Yang
2023-06-20 19:37 ` Vagrant Cascadian
2 siblings, 0 replies; 5+ messages in thread
From: Kever Yang @ 2023-05-18 0:57 UTC (permalink / raw)
To: Wolfgang Zarre, u-boot, Simon Glass, Philipp Tomsich; +Cc: Peter Robinson
On 2023/5/1 15:43, Wolfgang Zarre wrote:
> If u-boot is installed on the internal emmc, then this will
> allow to boot without failure.
>
> Signed-off-by: Wolfgang Zarre <lxdev12@zirdeon.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
>
> configs/pinebook-pro-rk3399_defconfig | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig
> index dff4695e37..58a8b91aa6 100644
> --- a/configs/pinebook-pro-rk3399_defconfig
> +++ b/configs/pinebook-pro-rk3399_defconfig
> @@ -6,6 +6,7 @@ CONFIG_TEXT_BASE=0x00200000
> CONFIG_NR_DRAM_BANKS=1
> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
> +CONFIG_SF_DEFAULT_SPEED=20000000
> CONFIG_ENV_SIZE=0x8000
> CONFIG_ENV_OFFSET=0x3F8000
> CONFIG_DEFAULT_DEVICE_TREE="rk3399-pinebook-pro"
> @@ -18,6 +19,7 @@ CONFIG_DEBUG_UART_CLOCK=24000000
> CONFIG_SPL_SPI_FLASH_SUPPORT=y
> CONFIG_SPL_SPI=y
> CONFIG_SYS_LOAD_ADDR=0x800800
> +CONFIG_PCI=y
> CONFIG_DEBUG_UART=y
> CONFIG_BOOTDELAY=3
> CONFIG_USE_PREBOOT=y
> @@ -57,17 +59,23 @@ CONFIG_LED=y
> CONFIG_LED_GPIO=y
> CONFIG_MISC=y
> CONFIG_ROCKCHIP_EFUSE=y
> +CONFIG_MMC_IO_VOLTAGE=y
> +CONFIG_SPL_MMC_IO_VOLTAGE=y
> +CONFIG_MMC_UHS_SUPPORT=y
> +CONFIG_SPL_MMC_UHS_SUPPORT=y
> +CONFIG_MMC_HS400_ES_SUPPORT=y
> +CONFIG_SPL_MMC_HS400_ES_SUPPORT=y
> +CONFIG_MMC_HS400_SUPPORT=y
> +CONFIG_SPL_MMC_HS400_SUPPORT=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_SDMA=y
> CONFIG_MMC_SDHCI_ROCKCHIP=y
> CONFIG_SF_DEFAULT_BUS=1
> -CONFIG_SF_DEFAULT_SPEED=20000000
> CONFIG_SPI_FLASH_GIGADEVICE=y
> CONFIG_SPI_FLASH_WINBOND=y
> CONFIG_NVME_PCI=y
> -CONFIG_PCI=y
> CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> CONFIG_PHY_ROCKCHIP_TYPEC=y
> CONFIG_DM_PMIC_FAN53555=y
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rockchip: Pinebook Pro: Fix emmc default configuration
2023-05-01 7:43 [PATCH] rockchip: Pinebook Pro: Fix emmc default configuration Wolfgang Zarre
2023-05-01 19:28 ` Peter Robinson
2023-05-18 0:57 ` Kever Yang
@ 2023-06-20 19:37 ` Vagrant Cascadian
2 siblings, 0 replies; 5+ messages in thread
From: Vagrant Cascadian @ 2023-06-20 19:37 UTC (permalink / raw)
To: u-boot, Simon Glass, Kever Yang, Philipp Tomsich
Cc: Wolfgang Zarre, Peter Robinson
[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]
On 2023-05-01, Wolfgang Zarre wrote:
> If u-boot is installed on the internal emmc, then this will
> allow to boot without failure.
>
> Signed-off-by: Wolfgang Zarre <lxdev12@zirdeon.com>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
This is marked as accepted in patchwork, but I do not see it in git
yet...
Is this planned to land in 2023.07(-rc5?)?
Thanks!
live well,
vagrant
> configs/pinebook-pro-rk3399_defconfig | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig
> index dff4695e37..58a8b91aa6 100644
> --- a/configs/pinebook-pro-rk3399_defconfig
> +++ b/configs/pinebook-pro-rk3399_defconfig
> @@ -6,6 +6,7 @@ CONFIG_TEXT_BASE=0x00200000
> CONFIG_NR_DRAM_BANKS=1
> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x300000
> +CONFIG_SF_DEFAULT_SPEED=20000000
> CONFIG_ENV_SIZE=0x8000
> CONFIG_ENV_OFFSET=0x3F8000
> CONFIG_DEFAULT_DEVICE_TREE="rk3399-pinebook-pro"
> @@ -18,6 +19,7 @@ CONFIG_DEBUG_UART_CLOCK=24000000
> CONFIG_SPL_SPI_FLASH_SUPPORT=y
> CONFIG_SPL_SPI=y
> CONFIG_SYS_LOAD_ADDR=0x800800
> +CONFIG_PCI=y
> CONFIG_DEBUG_UART=y
> CONFIG_BOOTDELAY=3
> CONFIG_USE_PREBOOT=y
> @@ -57,17 +59,23 @@ CONFIG_LED=y
> CONFIG_LED_GPIO=y
> CONFIG_MISC=y
> CONFIG_ROCKCHIP_EFUSE=y
> +CONFIG_MMC_IO_VOLTAGE=y
> +CONFIG_SPL_MMC_IO_VOLTAGE=y
> +CONFIG_MMC_UHS_SUPPORT=y
> +CONFIG_SPL_MMC_UHS_SUPPORT=y
> +CONFIG_MMC_HS400_ES_SUPPORT=y
> +CONFIG_SPL_MMC_HS400_ES_SUPPORT=y
> +CONFIG_MMC_HS400_SUPPORT=y
> +CONFIG_SPL_MMC_HS400_SUPPORT=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_SDMA=y
> CONFIG_MMC_SDHCI_ROCKCHIP=y
> CONFIG_SF_DEFAULT_BUS=1
> -CONFIG_SF_DEFAULT_SPEED=20000000
> CONFIG_SPI_FLASH_GIGADEVICE=y
> CONFIG_SPI_FLASH_WINBOND=y
> CONFIG_NVME_PCI=y
> -CONFIG_PCI=y
> CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> CONFIG_PHY_ROCKCHIP_TYPEC=y
> CONFIG_DM_PMIC_FAN53555=y
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-20 19:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-01 7:43 [PATCH] rockchip: Pinebook Pro: Fix emmc default configuration Wolfgang Zarre
2023-05-01 19:28 ` Peter Robinson
2023-05-02 10:20 ` Wolf
2023-05-18 0:57 ` Kever Yang
2023-06-20 19:37 ` Vagrant Cascadian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox