Re: [PATCH v2 01/17] android: boot: rename andr_img_hdr -> andr_boot_img_hdr_v0

Simon Glass
2023-01-27T00:55:44Z

Hi Safae,

On Thu, 26 Jan 2023 at 09:05, Safae Ouajih <souajih@baylibre.com> wrote:
>
> Android introduced boot header version 3 or 4.
> The header structure change with version 3 and 4 to support
> the new updates such as:
> - Introducing Vendor boot image: with a vendor ramdisk
> - Bootconfig feature (v4)
>
> To maintain support for version v0, v1 and v2 while introducing
> version 3 and 4, this struct name must change to refer to the header
> structure before v3.
>
> Signed-off-by: Safae Ouajih <souajih@baylibre.com>
> ---
> boot/image-android.c | 26 +++++++++++++-------------
> boot/image-fdt.c | 2 +-
> cmd/abootimg.c | 4 ++--
> drivers/fastboot/fb_mmc.c | 8 ++++----
> include/android_image.h | 4 ++--
> include/image.h | 18 +++++++++---------
> 6 files changed, 31 insertions(+), 31 deletions(-)

Please add full comments to the functions you change in image.h

With that:

Reviewed-by: Simon Glass <sjg@chromium.org>