Re: [PATCH v2 07/17] android: boot: content print is not supported for v3,v4 header version

Simon Glass
2023-01-27T17:18:03Z

On Fri, 27 Jan 2023 at 08:50, Safae Ouajih <souajih@baylibre.com> wrote:
>
>
> On 27/01/2023 01:54, Simon Glass wrote:
> > Hi Safae,
> >
> > On Thu, 26 Jan 2023 at 09:05, Safae Ouajih <souajih@baylibre.com> wrote:
> >> Content print is not supported for version 3 and 4 of boot image header.
> >> Thus, only print that content when v2 is used.
> >>
> >> Update android_print_contents() to print an error message
> >> when trying to print boot image header version 3 or 4 content.
> >>
> >> Signed-off-by: Safae Ouajih <souajih@baylibre.com>
> >> ---
> >> boot/image-android.c | 6 +++++-
> >> 1 file changed, 5 insertions(+), 1 deletion(-)
> >>
> > Why is that?
> >
> > Regards,
> > Simon
>
> Hi Simon,
>
> Thank you for the review.
>
> Content print for boot image header v4 can be supported
>
> and only requires updating the existing functions.
>
> This is something I intend to support later on.

OK thanks

Reviewed-by: Simon Glass <sjg@chromium.org>