Re: [PATCH v2 06/17] android: boot: move to andr_image_data structure

Safae Ouajih
2023-01-27T15:50:50Z

On 27/01/2023 01:54, Simon Glass wrote:
> Hi Safae,
>
> On Thu, 26 Jan 2023 at 09:05, Safae Ouajih <souajih@baylibre.com> wrote:
>> Move from andr_boot_img_hdr_v0 to andr_image_data
>> structure to prepare for boot image header
>> version 3 and 4.
>>
>> Signed-off-by: Safae Ouajih <souajih@baylibre.com>
>> ---
>> boot/image-android.c | 127 ++++++++++++++++++++++++-------------------
>> cmd/abootimg.c | 31 ++++++-----
>> include/image.h | 2 +
>> 3 files changed, 89 insertions(+), 71 deletions(-)
>>
> Do you need the #ifdef CONFIG_CMD_ABOOTIMG? We try to avoid adding those.
>
> Regards,
> Simon

Hi Simon,

This is needed to avoid warnings such as "unused function warnings" when

CONFIG_CMD_ABOOTIMG is not defined.

Best regards,

--safae