From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>
Subject: Re: [PATCH v5 6/6] patman: additionally honor a local .patman config file
Date: Tue, 20 Dec 2022 20:56:16 -0500 [thread overview]
Message-ID: <878rj14j0f.fsf@gmail.com> (raw)
In-Reply-To: <CAPnjgZ22koVFLVq=Ua2qZ6Vr8mXOae=bvVh_KhhyBgq=TvM7yw@mail.gmail.com> (Simon Glass's message of "Wed, 21 Dec 2022 00:28:29 +0000")
Hi Simon,
Simon Glass <sjg@chromium.org> writes:
> On Mon, 19 Dec 2022 at 22:38, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>>
>> This enables versioning a project specific patman configuration file.
>> It also makes it possible to declare the project name, which is not a
>> useful thing to do in $HOME/.patman. A new test is added, along
>> updated documentation.
>>
>> Signed-off-by: Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>
>> ---
>>
>> Changes in v5:
>> - Use try/finally in cleared_command_line_args context manager
>>
>> Changes in v4:
>> - Use tools.run to invoke git in test suite
>>
>> Changes in v3:
>> - Clear command line arguments in test_git_local_config
>> - Also test overriding a 'send' command line argument
>>
>> Changes in v2:
>> - Explicitly provide an empty args list to parse_known_args in test
>>
>> tools/patman/patman.rst | 8 ++++-
>> tools/patman/settings.py | 24 ++++++++++---
>> tools/patman/test_settings.py | 67 +++++++++++++++++++++++++++++++++++
>> 3 files changed, 94 insertions(+), 5 deletions(-)
>> create mode 100644 tools/patman/test_settings.py
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Applied to u-boot-dm/next, thanks!
Great, thank you for the review and seeing it through!
--
Thanks,
Maxim
prev parent reply other threads:[~2022-12-21 1:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 5:38 [PATCH v5 0/6] add support for repository-local .patman config file Maxim Cournoyer
2022-12-20 5:38 ` [PATCH v5 1/6] patman: fix pep8 warnings in settings module Maxim Cournoyer
2022-12-20 16:25 ` Simon Glass
2022-12-21 0:28 ` Simon Glass
2022-12-20 5:38 ` [PATCH v5 2/6] patman: replace deprecated SafeConfigParser with ConfigParser Maxim Cournoyer
2022-12-20 16:25 ` Simon Glass
2022-12-21 0:28 ` Simon Glass
2022-12-20 5:38 ` [PATCH v5 3/6] patman: import gitutil module where it is needed Maxim Cournoyer
2022-12-20 16:25 ` Simon Glass
2022-12-21 0:28 ` Simon Glass
2022-12-20 5:38 ` [PATCH v5 4/6] patman: set the default config_fname argument value to None Maxim Cournoyer
2022-12-20 16:25 ` Simon Glass
2022-12-21 0:28 ` Simon Glass
2022-12-20 5:38 ` [PATCH v5 5/6] patman: fail early in Setup when provided config file does not exist Maxim Cournoyer
2022-12-20 16:25 ` Simon Glass
2022-12-21 0:28 ` Simon Glass
2022-12-20 5:38 ` [PATCH v5 6/6] patman: additionally honor a local .patman config file Maxim Cournoyer
2022-12-20 16:25 ` Simon Glass
2022-12-21 0:28 ` Simon Glass
2022-12-21 1:56 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rj14j0f.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=maxim.cournoyer@savoirfairelinux.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox