Re: [PATCH v5 6/6] patman: additionally honor a local .patman config file

Maxim Cournoyer
2022-12-21T01:56:25Z

Hi Simon,

Simon Glass <sjg@chromium.org> writes:

> On Mon, 19 Dec 2022 at 22:38, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>>
>> This enables versioning a project specific patman configuration file.
>> It also makes it possible to declare the project name, which is not a
>> useful thing to do in $HOME/.patman. A new test is added, along
>> updated documentation.
>>
>> Signed-off-by: Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>
>> ---
>>
>> Changes in v5:
>> - Use try/finally in cleared_command_line_args context manager
>>
>> Changes in v4:
>> - Use tools.run to invoke git in test suite
>>
>> Changes in v3:
>> - Clear command line arguments in test_git_local_config
>> - Also test overriding a 'send' command line argument
>>
>> Changes in v2:
>> - Explicitly provide an empty args list to parse_known_args in test
>>
>> tools/patman/patman.rst | 8 ++++-
>> tools/patman/settings.py | 24 ++++++++++---
>> tools/patman/test_settings.py | 67 +++++++++++++++++++++++++++++++++++
>> 3 files changed, 94 insertions(+), 5 deletions(-)
>> create mode 100644 tools/patman/test_settings.py
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Applied to u-boot-dm/next, thanks!

Great, thank you for the review and seeing it through!

--
Thanks,
Maxim