From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15A51C4332F for ; Wed, 12 Oct 2022 17:39:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB45584E37; Wed, 12 Oct 2022 19:39:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=debian.org header.i=@debian.org header.b="gTxCuLK/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DE63B84E4C; Wed, 12 Oct 2022 19:39:13 +0200 (CEST) Received: from cascadia.aikidev.net (cascadia.aikidev.net [IPv6:2600:3c01:e000:267:0:a171:de7:c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BA181848C2 for ; Wed, 12 Oct 2022 19:39:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=vagrant@debian.org Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 1F8EA1ABF9; Wed, 12 Oct 2022 10:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1665596348; bh=7PJ0IseGCPJ0McZ1F+MgMPixcrscRDn7AbqjWhFVOX8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gTxCuLK/GYyJbE9q2ui98PQuKjXr9hETpvF/Qqfi9SyM520Bbb2eMhGxXXfjUbcJA D2ucstSqEYPEsnvFPV7uqeY8AVMD8Lxxm0fB9F5q1hbMgM5607lETLinaszzspiAdO D+85UWQuK8z/hT2xTZsyoy0twswaeVtFNPH6EstDQSOaMI9G1yoOMN3KtOCvXluK9W 6dSK9b1Enj8KKzmZA6lWptjS9NWLfZoMihSjSYpeGoj7Wg74c6KOzvSGEx0HmN2Zsm MSYZFJjIqNE8rkxT4jtd4/8RMeGQQ8EQ7lbyU2Hp5bBS9drG3ILDau53HoIeFkZzla upJn0tLDLyS1Q== From: Vagrant Cascadian To: Tom Rini , Andrey Skvortsov Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Peter Robinson , Alexander Graf , Samuel Holland Subject: Re: [PATCH] distro_bootcmd: Always check for custom boot scripts first In-Reply-To: <20221012165016.GA328460@bill-the-cat> References: <20220901220616.25814-1-andrej.skvortzov@gmail.com> <20221012165016.GA328460@bill-the-cat> Date: Wed, 12 Oct 2022 10:39:03 -0700 Message-ID: <878rllj614.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2022-10-12, Tom Rini wrote: > On Fri, Sep 02, 2022 at 01:06:16AM +0300, Andrey Skvortsov wrote: >> If extlinux.conf is used, then it's not possible to customize boot >> environment, because scripts are not loaded. >> Usually it's possible to make some changes manually using command line >> and save boot environment. But if exlinux.conf is loaded >> from ext4 partition (for example on PinePhone), then environment are >> not saved/loaded at boot time from boot partition and it's not >> possible to persistently change boot environment without recompiling >> u-boot. >>=20 >> Signed-off-by: Andrey Skvortsov >> --- >>=20 >> include/config_distro_bootcmd.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/include/config_distro_bootcmd.h b/include/config_distro_boo= tcmd.h >> index 5506f3168f..7f4ef960a1 100644 >> --- a/include/config_distro_bootcmd.h >> +++ b/include/config_distro_bootcmd.h >> @@ -477,8 +477,8 @@ >> "echo Scanning ${devtype} " \ >> "${devnum}:${distro_bootpart}...; " \ >> "for prefix in ${boot_prefixes}; do " \ >> - "run scan_dev_for_extlinux; " \ >> "run scan_dev_for_scripts; " \ >> + "run scan_dev_for_extlinux; " \ >> "done;" \ >> SCAN_DEV_FOR_EFI \ >> "\0" \ > > Reworking the CC list a bit, I think this works against the intent. If > the distro provides extlinux.conf, that's what should be used, and > customized by the user (through normal distro methods), rather than > looking for a boot script that might be out of date / etc. Can you > please elaborate on what you're seeing and trying to do on the > PinePhone? With my Debian hat on, I would prefer to not change default behaviors; these have been present in this order for many years now. It is also not uncommon (for better or worse) for a Debian system to have both a boot script and an extlinux.conf, and possibly an EFI boot option, so this would be a significant behavior change... There are definitely cases where the flexibility of a bootscript might be preferred, but in those cases, one should remove the extlinux.conf and the packaging hooks that generate it (e.g. u-boot-menu package on debian). Alternately, adding another search for a bootscript at a different path before extlinux.conf is loaded *might* be worth considering, but not sure the extra complication and duplication is worth it... Also curious on the status of "U-boot Standard Boot" https://u-boot.readthedocs.io/en/latest/develop/bootstd.html which might solve some of these problems? live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY0b7twAKCRDcUY/If5cW qsynAP9n+R8MMlVYqfnou2b+KNH4BpZuNvTbsca14T90YmrDCgEA5qYQ/Z0DWqaY 3LQMGO8sXVJXU91xLNAKPb2QSQVQrQM= =T7bT -----END PGP SIGNATURE----- --=-=-=--