From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: u-boot@lists.denx.de
Subject: [patch 3/8] RFC: drivers/video/rockchip/rk_edp.c: Change interrupt polarity configuration
Date: Fri, 23 Oct 2020 10:51:15 +0200 [thread overview]
Message-ID: <878sbx496k.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <a7d2bca3-ac34-6af4-11a8-9153ba26ebd4@gmail.com> (Alper Nebi Yasak's message of "Thu, 22 Oct 2020 21:39:29 +0300")
Alper Nebi Yasak <alpernebiyasak@gmail.com> writes:
> On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote:
>> The linux code is setting polarity configuration to 3 but
>> uboot code is setting it to 1. Change the configuration to match the
>> linux configuration
> FYI, coreboot does the same as existing code, but Linux support for this
> is bound to be better than both coreboot and U-Boot.
>
>>
>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>> Index: u-boot/drivers/video/rockchip/rk_edp.c
>> ===================================================================
>> --- u-boot.orig/drivers/video/rockchip/rk_edp.c
>> +++ u-boot/drivers/video/rockchip/rk_edp.c
>> @@ -100,10 +100,13 @@ static void rk_edp_init_refclk(struct rk
>> ®s->dp_reserv2);
>> }
>>
>> +#define INT_POL1 (0x1 << 1)
>> +#define INT_POL0 (0x1 << 0)
>> +
>
> INT_POL is defined at arch/arm/include/asm/arch-rockchip/edp_rk3288.h,
> so these would probably go there.
>
I've been wondering were to put them tbh. I'll move them to edp_rk3288.h
then.
Arnaud
next prev parent reply other threads:[~2020-10-23 8:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 18:36 [patch 0/8] RFC: Pinebook pro EDP support Arnaud Patard
2020-09-25 18:36 ` [patch 1/8] RFC: drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode Arnaud Patard
2020-09-28 2:44 ` Kever Yang
2020-09-25 18:36 ` [patch 2/8] RFC: drivers/video/rockchip/rk_edp.c: Add rk3399 support Arnaud Patard
2020-10-22 18:32 ` Alper Nebi Yasak
2020-10-23 8:49 ` Arnaud Patard
2020-10-23 10:14 ` Alper Nebi Yasak
2020-09-25 18:36 ` [patch 3/8] RFC: drivers/video/rockchip/rk_edp.c: Change interrupt polarity configuration Arnaud Patard
2020-10-22 18:39 ` Alper Nebi Yasak
2020-10-23 8:51 ` Arnaud Patard [this message]
2020-09-25 18:36 ` [patch 4/8] RFC: drivers/video/rockchip/rk_edp.c: Change clock rate Arnaud Patard
2020-10-22 18:49 ` Alper Nebi Yasak
2020-10-23 9:01 ` Arnaud Patard
2020-09-25 18:36 ` [patch 5/8] RFC: drivers/video/rockchip/rk_vop.c: Reserve efi fb memory Arnaud Patard
2020-09-25 18:37 ` [patch 6/8] RFC: rk3399-pinebook-pro-u-boot.dtsi: Enable edp Arnaud Patard
2020-09-25 18:37 ` [patch 7/8] RFC: configs/pinebook-pro-rk3399_defconfig: enable SYS_USB_EVENT_POLL_VIA_INT_QUEUE Arnaud Patard
2020-09-25 18:37 ` [patch 8/8] RFC: drivers/pwm/rk_pwm.c: Fix default polarity Arnaud Patard
2020-09-27 15:53 ` [patch 0/8] RFC: Pinebook pro EDP support Alper Nebi Yasak
2020-09-28 6:41 ` Arnaud Patard
2020-09-28 17:18 ` Alper Nebi Yasak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sbx496k.fsf@lechat.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox