From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix USB devices with multiple configurations
Date: Thu, 10 Jul 2008 11:36:41 +0200 [thread overview]
Message-ID: <878wwa2i8m.fsf@denx.de> (raw)
In-Reply-To: <20080709221101.3E0B324304@gemini.denx.de> (Wolfgang Denk's message of "Thu\, 10 Jul 2008 00\:11\:01 +0200")
Wolfgang Denk <wd@denx.de> writes:
> In message <20080706165805.GG20299@prithivi.gnumonks.org> you wrote:
>>
>> This patch fixes bugs in usbdcore*.c related to the use of devices
>> with multiple configurations.
>>
>> The original code made mistakes about the meaning of configuration value and
>> configuration index, and the resulting off-by-one errors resulted in:
>>
>> * SET_CONFIGURATION always selected the first configuration, no matter what
>> wValue is being passed.
>> * GET_DESCRIPTOR/CONFIGURATION always returned the descriptor for the first
>> configuration (index 0).
>>
>> Signed-off-by: Harald Welte <laforge@openmoko.org>
Acked-by: Markus Klotzbuecher <mk@denx.de>
> Markus, are you going to add this to the USB repo any time soon?
>
> Or you could just ACK it (if you think so) and tell me to pick up
> directly.
Wolfgang, please apply.
Sorry for the delay.
Best regards
Markus Klotzbuecher
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2008-07-10 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-06 16:58 [U-Boot-Users] [PATCH] fix USB devices with multiple configurations Harald Welte
2008-07-09 22:11 ` Wolfgang Denk
2008-07-10 9:36 ` Markus Klotzbücher [this message]
2008-07-10 10:00 ` Wolfgang Denk
[not found] ` <20080828235516.GB30743@game.jcrosoft.org>
2008-08-29 6:07 ` [U-Boot] " Markus Klotzbücher
2008-07-10 9:59 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wwa2i8m.fsf@denx.de \
--to=mk@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox