From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?utf-8?Q?Klotzb=C3=BCcher?= Date: Thu, 10 Jul 2008 11:36:41 +0200 Subject: [U-Boot-Users] [PATCH] fix USB devices with multiple configurations In-Reply-To: <20080709221101.3E0B324304@gemini.denx.de> (Wolfgang Denk's message of "Thu\, 10 Jul 2008 00\:11\:01 +0200") References: <20080709221101.3E0B324304@gemini.denx.de> Message-ID: <878wwa2i8m.fsf@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk writes: > In message <20080706165805.GG20299@prithivi.gnumonks.org> you wrote: >> >> This patch fixes bugs in usbdcore*.c related to the use of devices >> with multiple configurations. >> >> The original code made mistakes about the meaning of configuration value and >> configuration index, and the resulting off-by-one errors resulted in: >> >> * SET_CONFIGURATION always selected the first configuration, no matter what >> wValue is being passed. >> * GET_DESCRIPTOR/CONFIGURATION always returned the descriptor for the first >> configuration (index 0). >> >> Signed-off-by: Harald Welte Acked-by: Markus Klotzbuecher > Markus, are you going to add this to the USB repo any time soon? > > Or you could just ACK it (if you think so) and tell me to pick up > directly. Wolfgang, please apply. Sorry for the delay. Best regards Markus Klotzbuecher -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de