Re: [PATCH v3 3/3] Add imx93-var-som support

[Mathieu Othacehe <m.othacehe@gmail.com>]

Hello Fabio,

> I applied this patch against U-Boot's next branch.
>
> I had to manually add:

I was testing on 2023.10. I rebased the series on `next` on my side. I
had to do something similar to fb2bdc4efcb in order to fix booting.

> $ git am ~/Downloads/Add-imx93-var-som-support.patch
> Applying: spl: binman: Disable u_boot_any symbols for i.MX93 boards
> Applying: mach-imx: Add i.MX93 binman support.
> Applying: Add imx93-var-som support
> .git/rebase-apply/patch:3025: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.

Fixed.

>> +#include "imx93-u-boot.dtsi"
>
> This file should be included by default. No need to manually include it.

I am not sure why but without this include, I have the following
warning:

binman: Device tree 'u-boot.dtb' does not have a 'binman' node

which seem to indicate that this include is needed.

> Not needed to be done in this series, but in the future, it would be
> nice to convert this wdog driver to DM.

Noted.

I will send a v4 that should take all remarks into account.

Thanks,

Mathieu