From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Marek Vasut <marex@denx.de>, u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>, Angus Ainslie <angus@akkea.ca>,
Dmitrii Merkurev <dimorinny@google.com>,
Eddie Cai <eddie.cai.linux@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>,
Lukasz Majewski <lukma@denx.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Nishanth Menon <nm@ti.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Simon Glass <sjg@chromium.org>, Stefan Roese <sr@denx.de>,
kernel@puri.sm
Subject: Re: [PATCH v2 14/17] usb: gadget: acm: Use plain udevice for UDC controller interaction
Date: Mon, 04 Sep 2023 09:46:24 +0200 [thread overview]
Message-ID: <87a5u22xf3.fsf@baylibre.com> (raw)
In-Reply-To: <20230901095003.352930-14-marex@denx.de>
On ven., sept. 01, 2023 at 11:50, Marek Vasut <marex@denx.de> wrote:
> Convert to plain udevice interaction with UDC controller
> device, avoid the use of UDC uclass dev_array .
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> Cc: Angus Ainslie <angus@akkea.ca>
> Cc: Dmitrii Merkurev <dimorinny@google.com>
> Cc: Eddie Cai <eddie.cai.linux@gmail.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Philipp Tomsich <philipp.tomsich@vrull.eu>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stefan Roese <sr@denx.de>
> Cc: kernel@puri.sm
> ---
> V2: No change
> ---
> drivers/usb/gadget/f_acm.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_acm.c
> index b2ddd1ada8b..de42e0189e8 100644
> --- a/drivers/usb/gadget/f_acm.c
> +++ b/drivers/usb/gadget/f_acm.c
> @@ -51,7 +51,7 @@ struct f_acm {
> #define ACM_CTRL_RTS BIT(1) /* unused with full duplex */
> #define ACM_CTRL_DTR BIT(0) /* host is ready for data r/w */
>
> - int controller_index;
> + struct udevice *udc;
> };
>
> static struct f_acm *default_acm_function;
> @@ -489,7 +489,7 @@ static void __acm_tx(struct f_acm *f_acm)
> int len, ret;
>
> do {
> - usb_gadget_handle_interrupts(f_acm->controller_index);
> + dm_usb_gadget_handle_interrupts(f_acm->udc);
>
> if (!(f_acm->handshake_bits & ACM_CTRL_DTR))
> break;
> @@ -520,7 +520,7 @@ static bool acm_connected(struct stdio_dev *dev)
> struct f_acm *f_acm = stdio_to_acm(dev);
>
> /* give a chance to process udc irq */
> - usb_gadget_handle_interrupts(f_acm->controller_index);
> + dm_usb_gadget_handle_interrupts(f_acm->udc);
>
> return f_acm->connected;
> }
> @@ -543,7 +543,10 @@ static int acm_add(struct usb_configuration *c)
> f_acm->usb_function.descriptors = acm_fs_function;
> f_acm->usb_function.hs_descriptors = acm_hs_function;
> f_acm->usb_function.setup = acm_setup;
> - f_acm->controller_index = 0;
> +
> + status = udc_device_get_by_index(0, &f_acm->udc);
> + if (status)
> + return status;
>
> status = usb_add_function(c, &f_acm->usb_function);
> if (status) {
> @@ -567,7 +570,7 @@ static int acm_stdio_tstc(struct stdio_dev *dev)
> {
> struct f_acm *f_acm = stdio_to_acm(dev);
>
> - usb_gadget_handle_interrupts(f_acm->controller_index);
> + dm_usb_gadget_handle_interrupts(f_acm->udc);
>
> return (f_acm->rx_buf.size > 0);
> }
> --
> 2.40.1
next prev parent reply other threads:[~2023-09-04 7:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 9:49 [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions Marek Vasut
2023-09-01 9:49 ` [PATCH v2 02/17] usb: sandbox: Add DM_USB_GADGET support Marek Vasut
2023-09-01 9:49 ` [PATCH v2 03/17] configs: sandbox: Enable DM_USB_GADGET Marek Vasut
2023-09-01 9:49 ` [PATCH v2 04/17] cmd: fastboot: Use plain udevice for UDC controller interaction Marek Vasut
2023-09-01 9:49 ` [PATCH v2 05/17] cmd: rockusb: " Marek Vasut
2023-09-04 7:37 ` Mattijs Korpershoek
2023-09-01 9:49 ` [PATCH v2 06/17] cmd: sdp: Reorder variable declaration Marek Vasut
2023-09-01 9:49 ` [PATCH v2 07/17] cmd: thordown: " Marek Vasut
2023-09-04 7:40 ` Mattijs Korpershoek
2023-09-01 9:49 ` [PATCH v2 08/17] cmd: ums: Use plain udevice for UDC controller interaction Marek Vasut
2023-09-01 9:49 ` [PATCH v2 09/17] dfu: Detach the controller on error Marek Vasut
2023-09-01 9:49 ` [PATCH v2 10/17] dfu: Use plain udevice for UDC controller interaction Marek Vasut
2023-09-01 9:49 ` [PATCH v2 11/17] spl: sdp: Detach the controller on error Marek Vasut
2023-09-01 9:49 ` [PATCH v2 12/17] sdp: Use plain udevice for UDC controller interaction Marek Vasut
2023-09-01 9:49 ` [PATCH v2 13/17] thordown: " Marek Vasut
2023-09-04 7:45 ` Mattijs Korpershoek
2023-09-01 9:50 ` [PATCH v2 14/17] usb: gadget: acm: " Marek Vasut
2023-09-04 7:46 ` Mattijs Korpershoek [this message]
2023-09-01 9:50 ` [PATCH v2 15/17] usb: gadget: ether: " Marek Vasut
2023-09-04 7:56 ` Mattijs Korpershoek
2023-09-04 9:10 ` Marek Vasut
2023-09-04 15:37 ` Mattijs Korpershoek
2023-09-01 9:50 ` [PATCH v2 16/17] dm: usb: udc: Drop legacy udevice handler functions Marek Vasut
2023-09-01 9:50 ` [PATCH v2 17/17] board: usb: Replace legacy usb_gadget_handle_interrupts() Marek Vasut
2023-09-22 10:00 ` [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions Miquel Raynal
2023-09-27 13:59 ` Miquel Raynal
2023-09-30 21:11 ` Marek Vasut
2023-10-02 13:42 ` Miquel Raynal
2023-10-07 21:01 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5u22xf3.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=angus@akkea.ca \
--cc=dimorinny@google.com \
--cc=eddie.cai.linux@gmail.com \
--cc=kernel@puri.sm \
--cc=kever.yang@rock-chips.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=miquel.raynal@bootlin.com \
--cc=nm@ti.com \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox