From: Bill Pringlemeir <bpringlemeir@nbsps.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds
Date: Fri, 21 Nov 2014 11:45:27 -0500 [thread overview]
Message-ID: <87a93klcyg.fsf@nbsps.com> (raw)
In-Reply-To: <a9e10ff92ccc971ec0fb090a3669c60a@agner.ch> (Stefan Agner's message of "Fri, 21 Nov 2014 16:10:04 +0100")
> On 2014-11-20 20:14, Jeroen Hofstee wrote:
>> Ok thanks for digging that up, that doesn't sound like a problem
>> then. Stefan, can you check if you can actually fix the warnings
>> instead of suppressing them?
On 21 Nov 2014, stefan at agner.ch wrote:
> Ok, I could apply the changes from your patch and it fixed the
> warnings in memset.S. However, when I build the file in ARM mode then
> (without CONFIG_SYS_THUMB_BUILD set). I get this:
> arch/arm/lib/memset.S: Assembler messages: arch/arm/lib/memset.S:92:
> Error: bad instruction `stmiage ip!,{r1,r3-r8,lr}'
I think you need '.syntax unified' if you want those in ARM mode. I
guess you found that out too? I see,
+ .syntax unified
+#ifdef CONFIG_SYS_THUMB_BUILD
+ .thumb
+ .thumb_func
+#endif
in '[PATCH v2] arm: build arch memset/memcpy in Thumb2 mode'; so this
solved it?
I think it is a very nice feature to have Thumb2 on Vybrid. Many boot
devices may have limited bandwidth compared to the running system.
Thanks for your work.
Regards,
Bill Pringlemeir
next prev parent reply other threads:[~2014-11-21 16:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 14:16 [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds Stefan Agner
2014-11-20 9:21 ` Jeroen Hofstee
2014-11-20 12:15 ` Stefan Agner
2014-11-20 13:10 ` Jeroen Hofstee
2014-11-20 15:18 ` Bill Pringlemeir
2014-11-20 15:53 ` Jeroen Hofstee
2014-11-20 18:21 ` Bill Pringlemeir
2014-11-20 19:14 ` Jeroen Hofstee
2014-11-21 15:10 ` Stefan Agner
2014-11-21 16:45 ` Bill Pringlemeir [this message]
2014-11-21 15:43 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a93klcyg.fsf@nbsps.com \
--to=bpringlemeir@nbsps.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox