From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bill Pringlemeir Date: Fri, 21 Nov 2014 11:45:27 -0500 Subject: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds In-Reply-To: (Stefan Agner's message of "Fri, 21 Nov 2014 16:10:04 +0100") References: <1416406618-16276-1-git-send-email-stefan@agner.ch> <546DB29C.7060500@myspectrum.nl> <546DE833.3090707@myspectrum.nl> <87bno1nbo0.fsf@nbsps.com> <546E0E7D.90203@myspectrum.nl> <87vbm9lomc.fsf@nbsps.com> <546E3D79.60904@myspectrum.nl> Message-ID: <87a93klcyg.fsf@nbsps.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On 2014-11-20 20:14, Jeroen Hofstee wrote: >> Ok thanks for digging that up, that doesn't sound like a problem >> then. Stefan, can you check if you can actually fix the warnings >> instead of suppressing them? On 21 Nov 2014, stefan at agner.ch wrote: > Ok, I could apply the changes from your patch and it fixed the > warnings in memset.S. However, when I build the file in ARM mode then > (without CONFIG_SYS_THUMB_BUILD set). I get this: > arch/arm/lib/memset.S: Assembler messages: arch/arm/lib/memset.S:92: > Error: bad instruction `stmiage ip!,{r1,r3-r8,lr}' I think you need '.syntax unified' if you want those in ARM mode. I guess you found that out too? I see, + .syntax unified +#ifdef CONFIG_SYS_THUMB_BUILD + .thumb + .thumb_func +#endif in '[PATCH v2] arm: build arch memset/memcpy in Thumb2 mode'; so this solved it? I think it is a very nice feature to have Thumb2 on Vybrid. Many boot devices may have limited bandwidth compared to the running system. Thanks for your work. Regards, Bill Pringlemeir