public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] tools/mkimage: use lseek rather than fstat for file size for -l option
Date: Wed, 03 Dec 2008 13:08:52 +0100	[thread overview]
Message-ID: <87abbdxxyj.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20081203115559.5519F834B020@gemini.denx.de> (Wolfgang Denk's message of "Wed\, 03 Dec 2008 12\:55\:59 +0100")

>>>>> "Wolfgang" == Wolfgang Denk <wd@denx.de> writes:

Hi,

 Wolfgang> As mentioned before, this doesn't work because the length you are
 Wolfgang> checking is not the image length, but the device size.

Yes, because you rejected the patch to fix this.

So, what do you suggest?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2008-12-03 12:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03 11:35 [U-Boot] [PATCH v2] tools/mkimage: ignore trailing garbage Peter Korsgaard
2008-12-03 11:35 ` [U-Boot] [PATCH v2] tools/mkimage: use lseek rather than fstat for file size for -l option Peter Korsgaard
2008-12-03 11:55   ` Wolfgang Denk
2008-12-03 12:08     ` Peter Korsgaard [this message]
2008-12-03 11:55 ` [U-Boot] [PATCH v2] tools/mkimage: ignore trailing garbage Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87abbdxxyj.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox