[U-Boot-Users] [PATCH 1/2] mpc83xx: Add MPC837x PCIE controller RC mode

["Markus Klotzbücher" <mk@denx.de>]

Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> writes:

>> +
>> +	reg16 = in_le16(hose_cfg_base + PEX_LTSSM_STAT);
>> +	if (reg16 < 0x16) {
>> +		printf("No link\n");
>> +		hose->indirect_type = INDIRECT_TYPE_NO_PCIE_LINK;
>> +	} else {
>> +		printf("link\n");
>> +	}
> please remove the bracket on the else

Come on, this is being ridiculously pedantic.

And wrong by Linux coding style. Quoting from Documentation/CodingStyle

Do not unnecessarily use braces where a single statement will do.

if (condition)
        action();

This does not apply if one branch of a conditional statement is a single
statement. Use braces in both branches.

if (condition) {
        do_this();
        do_that();
} else {
        otherwise();
}

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de