From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?utf-8?Q?Klotzb=C3=BCcher?= Date: Tue, 25 Mar 2008 12:11:11 +0100 Subject: [U-Boot-Users] [PATCH 1/2] mpc83xx: Add MPC837x PCIE controller RC mode In-Reply-To: <20080325103613.GA32107@game.jcrosoft.org> (Jean-Christophe PLAGNIOL-VILLARD's message of "Tue\, 25 Mar 2008 11\:36\:13 +0100") References: <20080324184211.GA13282@localhost.localdomain> <20080325103613.GA32107@game.jcrosoft.org> Message-ID: <87abkndpo0.fsf_-_@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jean-Christophe PLAGNIOL-VILLARD writes: >> + >> + reg16 = in_le16(hose_cfg_base + PEX_LTSSM_STAT); >> + if (reg16 < 0x16) { >> + printf("No link\n"); >> + hose->indirect_type = INDIRECT_TYPE_NO_PCIE_LINK; >> + } else { >> + printf("link\n"); >> + } > please remove the bracket on the else Come on, this is being ridiculously pedantic. And wrong by Linux coding style. Quoting from Documentation/CodingStyle Do not unnecessarily use braces where a single statement will do. if (condition) action(); This does not apply if one branch of a conditional statement is a single statement. Use braces in both branches. if (condition) { do_this(); do_that(); } else { otherwise(); } Best regards Markus Klotzbuecher -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de