Re: [PATCH v2] imx: imx8mp: Add support for Polyhex Debix Model A SBC

[Milan Zamazal <mzamazal@redhat.com>]

Gilles Talis <gilles.talis@gmail.com> writes:

> Hi Milan,
>
> Le jeu. 7 déc. 2023 à 11:09, Milan Zamazal <mzamazal@redhat.com> a écrit :
>
>> Peng Fan <peng.fan@oss.nxp.com> writes:
>>
>> > On 5/24/2023 3:21 AM, Gilles Talis wrote:
>> >> Add support for the Polyhex Debix Model A SBC board.
>> >> It is an industrial grade single board computer based on
>> >> NXP's i.MX 8M Plus.
>> >> Currently supported interfaces are:
>> >> - Serial console
>> >> - Micro SD
>> >> - eQOS and FEC Ethernet
>> >> imx8mp-debix-model-a.dts is taken from Linux 6.3.
>> >> Signed-off-by: Gilles Talis<gilles.talis@gmail.com>
>> >
>> > Reviewed-by: Peng Fan <peng.fan@nxp.com>
>>
>> Do you know why the patch has been left (as far as I can see) without
>> further action?
>>
> I don't know. I assume the maintainer is very busy or has missed it. I was
> planning to do a resend in the next few weeks.
>
>
>>
>> BTW, I applied it to current master, compiled approximately following
>> https://docs.u-boot.org/en/latest/board/nxp/imx8mp_evk.html and tried to
>> use it on Debix Model A.  U-Boot starts but cannot find the partition
>> table on the SD card:
>>
>>   U-Boot SPL 2024.01-rc3-07226-g43f2873fa9-dirty (Jan 01 1980 - 00:00:00
>> +0000)
>>   Normal Boot
>>   WDT: Started watchdog@30280000 with servicing every 1000ms (60s
>> timeout)
>>   Trying to boot from BOOTROM
>>   Boot Stage: Primary boot
>>   image offset 0x8000, pagesize 0x200, ivt offset 0x0
>>   NOTICE: BL31: v2.2(release):rel_imx_5.4.70_2.3.6-0-g15e8ff164-dirty
>>   NOTICE:  BL31: Built : 00:00:00, Jan  1 1980
>>
>>
>>   U-Boot 2024.01-rc3-07226-g43f2873fa9-dirty (Jan 01 1980 - 00:00:00 +0000)
>>
>>   CPU:   Freescale i.MX8MP[8] rev1.1 at 1200 MHz
>>   Reset cause: POR
>>   Model: Polyhex Debix Model A i.MX8MPlus board
>>   DRAM:  2 GiB
>>   Core: 83 devices, 22 uclasses, devicetree: separate
>>   WDT: Started watchdog@30280000 with servicing every 1000ms (60s
>> timeout)
>>   MMC:   FSL_SDHC: 1, FSL_SDHC: 2
>>   Loading Environment from MMC... *** Warning - bad CRC, using default
>> environment
>>
>>   In:    serial@30890000
>>   Out:   serial@30890000
>>   Err:   serial@30890000
>>   Net:   eth1: ethernet@30bf0000 [PRIME]
>>   Hit any key to stop autoboot: 2 <0x08><0x08><0x08> 1 <0x08><0x08><0x08>
>> 0
>>   switch to partitions #0, OK
>>   mmc1 is current device
>>   Scanning mmc 1:1...
>>   ,** No partition table - mmc 1 **
>>   Couldn't find partition mmc 1:1
>>   ,** No partition table - mmc 1 **
>>   Couldn't find partition mmc 1:1
>>   ,** No partition table - mmc 1 **
>>   Couldn't find partition mmc 1:1
>>   ,** No partition table - mmc 1 **
>>   Couldn't find partition mmc 1:1
>>   ,** No partition table - mmc 1 **
>>   Couldn't find partition mmc 1:1
>>   ,** No partition table - mmc 1 **
>>   Couldn't find partition mmc 1:1
>>   ,** No partition table - mmc 1 **
>>   Couldn't find partition mmc 1:1
>>   <0x1b>7<0x1b>[r<0x1b>[999;999H<0x1b>[6n<0x1b>8Card did not respond to
>> voltage select! : -110
>>   No EFI system partition
>>   No EFI system partition
>>   Failed to persist EFI variables
>>   Remove /soc@0/bus@30800000/ethernet@30be0000:phy-reset-gpios
>>   BootOrder not defined
>>   EFI boot manager: Cannot load any image
>>   ,** No partition table - mmc 1 **
>>   Couldn't find partition mmc 1:1
>>   Card did not respond to voltage select! : -110
>>   u-boot=>
>>
>> When I use an old U-Boot blob provided by Debix, it boots fine from the
>> same SD card.  The SD card contains a Fedora aarch64 image with a msdos
>> partition table.
>>
>> Do you know what could be wrong?
>>
> Interesting. I don't have a clue yet,. but let me give it a try and come
> back to you. Where can I download the Fedora aarch64 image you mentioned
> above?

I flashed the image freshly, to another SD card, and it boots happily.
So I can confirm your patch works. :-)

I don't know what's wrong with the partition table on the original SD
card.  I manipulated with the partitions and their properties a bit
before but parted or the other versions of U-Boot I tried don't report
any problem.  Maybe the U-Boot version from master that I happened to
compile does something differently.  Anyway, it's unlikely to be related
to this patch as it boots fine on a freshly flashed SD card.

Thank you for the patch, hopefully it'll get merged.

Regards,
Milan