From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21C86C636CC for ; Wed, 8 Feb 2023 08:21:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA13185D79; Wed, 8 Feb 2023 09:21:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="IaDVpJ8d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E37585AA5; Wed, 8 Feb 2023 09:21:18 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 65EFB85D85 for ; Wed, 8 Feb 2023 09:21:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maz@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 07771B81C3B; Wed, 8 Feb 2023 08:20:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA483C433EF; Wed, 8 Feb 2023 08:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675844443; bh=ONq71fYMrZAWD3JTGD2PXjI1anhx0hv7UiaE0VvyXps=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IaDVpJ8d4uhIfQ5DShBAHlDFXpU+UdrckpjT7eWQRt/+5JZaqo7aO+fSrzSqBXvLy TjXKJLI3WvkO1LIM+lUso/zUi3FsoMtQ3ij9ojVAMJZISGE+tqw/Gd8uDINvW1Tqiu Q1213GZ8ZnXKukFSFhtXkRxORzPuP8i7k/A6LSm37ahlTAJHmX/CYfcL8B5n8Lgl00 CLqKen81qhbWQN4YecJOkVmoIqCUeTfwOMD3ZOBHptecTeKJtS2wWMxlq0AjjvV06C Ucdk+VEZDGnCIW+uHu+tQ4adOfoE7RTSvnndsRkJUhOTFlwkENrhEOo49O1AGf/sr9 p9Mo/ETHFgrnQ== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pPfh3-008awW-9V; Wed, 08 Feb 2023 08:20:41 +0000 Date: Wed, 08 Feb 2023 08:20:35 +0000 Message-ID: <87bkm41sbw.wl-maz@kernel.org> From: Marc Zyngier To: Paul Liu Cc: u-boot@lists.denx.de, Will Deacon , Tom Rini Subject: Re: [PATCH 1/2] arm: cpu: Add optional CMOs by VA In-Reply-To: References: <20230207162014.58664-1-paul.liu@linaro.org> <20230207162014.58664-2-paul.liu@linaro.org> <0acfdc333e22249784b4abd63d8d09e6@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: paul.liu@linaro.org, u-boot@lists.denx.de, willdeacon@google.com, trini@konsulko.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 07 Feb 2023 17:18:27 +0000, Paul Liu wrote: > > Hi Marc, > > I think you are the author. I'm just making some minor fixes and > then upstreaming to the mailing list. What is the correct way to > make the Signed-off-by list? In general, and unless you have completely rewritten the patch (it doesn't seem so in this particular case), you should keep the original authorship and sign-off chain, and add your own Signed-off-by: tag *after* the previous ones. You should also document what changes you have made, if any, when picking up the patch. When posting it, it should read something like: From: Random Developer Fix foo handling in bar(). Signed-off-by: Random Developer Signed-off-by: Random Committer [Paul: picked from the FooBar tree, fixed the return value for bar() and rebased to upstream] Signed-off-by: Paul Liu Link: https://git.foobar.com/commit/?df2d85d0b0b5b1533d6db9079f0a0a7b73ef6a34 where "Random Developer" is the original author, and "Random Committer" is someone who picked up the patch the first place. The important thing here is that, just by looking at the sign-off chain, you can tell how the patch has been handled. The additional information (enclosed in square bracket) is optional but much appreciated by the reviewers, and so is the link to the original patch, which helps seeing it in context. If the commits have lost the original authorship (which sometimes happen as you rebase patches and resolve conflicts), you can fix it with: git commit --amend --author="Random Developer " on each individual commit. Tom's email also has a good pointer to what is expected from contributors (most of which is applicable to a large number of open-source projects). Hope this helps, M. -- Without deviation from the norm, progress is not possible.