From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62078C38142 for ; Wed, 1 Feb 2023 08:26:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D9ABA85AE9; Wed, 1 Feb 2023 09:26:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="JLzEZqgM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2A1AA85A49; Wed, 1 Feb 2023 09:26:16 +0100 (CET) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1C11685B65 for ; Wed, 1 Feb 2023 09:26:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wm1-x331.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso741695wms.4 for ; Wed, 01 Feb 2023 00:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Ht1LezkYQ/mfR3AAfmYWhtk2Xs4yXTsUZXxlPbrfwSQ=; b=JLzEZqgM/gpibW4mjveNYgJ/RvACaLQdRfXzKfhLkbZEATObPF5TyTgfZ8cBtMPifo 06HdfRJqVJd6ppqY2wwEvBFL+bHn73wbWk5JCcZ4ysT/ie5GnZtm/ooy+qAT8nXXrC7E rnSYXdd/e0MX6xBgFHSC2PHOuxzeCjKYz7sEatv1GnLWJf6MZtn7kOq1+sJzNRSCX5TD Pe6faN9hY3lUB3i7TeEOQ87ETBvY6uDt8IfCs21f6/LvFihbM77SlY+UM+Ku2cp7TJKz zD8b8oh0eWLIHAibmcQrX8Xad+zzCPkIYYIc4O2/X1UoBhmfs1qFVnQSH1dUaOl8JgO3 K9rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ht1LezkYQ/mfR3AAfmYWhtk2Xs4yXTsUZXxlPbrfwSQ=; b=VZ2l4qCbW238RHF5NlrT3wae4QcAEVkTU/1TzbUJem63iUIiChaH6t2yHcQmIjoWvY Iee9rSdAKuMKGdvphK+v2f+Lvlqck/c9lFBcolTD2kP7bNhl1OZVX0PkLN5Y5YKLYl5A 13hgzBfKCOHFbLID82/BwKxBabUxtOGJGYjEb/l+fLNo8Ho0dZlEUfy+umZFVMQB4I90 MrJjgTR4nbGPn6323LANCkxtxhgJuzlVc/Yaa10AjiGAbVW3BM5eoHlLGeJdpAGcDZfG otwvx7B7A4NgP4rZAUZOvqub14P6AUEWKdKJvmKFVG4OoNzFsRAa6EfPqgZjaBRp0/8w fs6A== X-Gm-Message-State: AO0yUKUU5yh/Zi8YsTwrdhGY1YuJK1yIDo3Bh6RdOxwx984fPcc9m3nd 6b/Zzq07urnA0pwnkRZ5rRuMmQ== X-Google-Smtp-Source: AK7set8EnQr13+oN2OG1+QGaFvt9QYE5n1Q0A49yPn+RkUKlHO8p6D4JhxInSjxbfMP5BOqf8GW3wQ== X-Received: by 2002:a05:600c:3ca4:b0:3dc:f24:f2de with SMTP id bg36-20020a05600c3ca400b003dc0f24f2demr1123209wmb.12.1675239968506; Wed, 01 Feb 2023 00:26:08 -0800 (PST) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id h5-20020a05600c2ca500b003db12112fcfsm1107983wmc.4.2023.02.01.00.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 00:26:08 -0800 (PST) From: Mattijs Korpershoek To: Safae Ouajih , sjg@chromium.org Cc: u-boot@lists.denx.de, sean.anderson@seco.com, r.stratiienko@gmail.com, glaroque@baylibre.com, khilman@baylibre.com Subject: Re: [PATCH v2 00/17] Support android boot image v3/v4 In-Reply-To: <20230126160506.1026643-1-souajih@baylibre.com> References: <20230126160506.1026643-1-souajih@baylibre.com> Date: Wed, 01 Feb 2023 09:26:04 +0100 Message-ID: <87bkmdkd0j.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Thu, Jan 26, 2023 at 17:04, Safae Ouajih wrote: > Hello everyone, > > * This is based on Roman Stratiienko's work to support boot image header version 3 and 4. > > * This supports the new boot image headers v3, v4 and bootconfig feature. > https://source.android.com/docs/core/architecture/bootloader/boot-image-header > https://source.android.com/docs/core/architecture/bootloader/implementing-bootconfig > > - Tested on Amlogic Khadas vim3l, a reference board for Android Open Source Project > https://www.khadas.com/vim3l > > And on AM625 Texas Instruments board with 5.10 linux kernel > > Main changes : > - New partition : vendor boot, with a specific vendor ramdisk > - DTB is stored in the vendor boot partition > - The generic ramdisk is placed after the vendor ramdisk > - Bootconfig feature support > > > Here is a link to see the related android boot flow changes on KHADAS vim3l as an example: > https://gitlab.baylibre.com/baylibre/amlogic/atv/u-boot/-/commits/souajih/BootImagev4/ > > Changes in v2: > - Rework parts of the code to fix the abootimg test: test_abootimg > - Update test_abootimg to support boot image header v4 > - Remove LIBXBC library, import and adapt the functions to support bootconfig feature > - Rename the used structures : > andr_boot_img_hdr_v0_v1_v2 -> andr_boot_img_hdr_v0 > andr_boot_img_hdr_v3_v4 -> andr_boot_img_hdr_v3 > andr_vendor_boot_img_hdr_v3_v4 -> andr_vendor_img_hdr Re-tested the whole series on Khadas vim3l board with boot header v2. Tested-by: Mattijs Korpershoek > > Safae Ouajih (17): > android: boot: rename andr_img_hdr -> andr_boot_img_hdr_v0 > android: boot: support vendor boot image in abootimg > android: boot: replace android_image_check_header > android: boot: add boot image header v3 and v4 structures > android: boot: kcomp: support andr_image_data > android: boot: move to andr_image_data structure > android: boot: content print is not supported for v3,v4 header version > android: boot: boot image header v3,v4 do not support recovery DTBO > android: boot: add vendor boot image to prepare for v3,v4 support > android: boot: update android_image_get_data to support v3,v4 > android: boot: ramdisk: support vendor ramdisk > android: boot: support extra command line > android: boot: update android_image_get_dtb_img_addr to support v3,v4 > drivers: fastboot: zImage flashing is not supported for v3,v4 > android: boot: support boot image header version 3 and 4 > android: boot: support bootconfig > test/py: android: extend abootimg test > > boot/bootm.c | 29 +- > boot/image-android.c | 467 ++++++++++++++++---- > boot/image-board.c | 15 +- > boot/image-fdt.c | 5 +- > cmd/abootimg.c | 75 +++- > drivers/fastboot/fb_mmc.c | 19 +- > include/android_image.h | 228 +++++++++- > include/image.h | 37 +- > test/py/tests/test_android/test_abootimg.py | 135 +++++- > 9 files changed, 850 insertions(+), 160 deletions(-) > > -- > 2.34.1