From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?iso-8859-1?Q?Klotzb=FCcher?= Date: Fri, 04 May 2007 12:20:37 +0200 Subject: [U-Boot-Users] PXA27x USB device In-Reply-To: <200705031029.39472.sr@denx.de> (Stefan Roese's message of "Thu, 3 May 2007 10:29:38 +0200") References: <20070502140500.GZ11009@enneenne.com> <87zm4m2vp7.fsf@denx.de> <200705031029.39472.sr@denx.de> Message-ID: <87bqh0j3ey.fsf@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, Stefan Roese writes: > On Thursday 03 May 2007 09:49, Markus Klotzb?cher wrote: >> Rodolfo Giometti writes: >> > I'm looking at drivers/usbdcore_mpc8xx.c for an implementation example >> > but I don't understand why such support has been put there instead of >> > cpu/mpc8xx directory. >> > >> > Can someone explain to me why? Should I put my PXA27x support also >> > there? >> >> I have no idea why this is so, but it does seem wrong to me. Platform >> specific code should go into the corresponding cpu/ directory, and so >> should your pxa support. >> >> Any objections? > > We had a lengthy discussion about the right places for such drivers a few > months ago. IIRC the consent was to put them into the drivers directory > (please correct me, if my memory fails me here). But we wanted to structure > this directly better. So I would suggest something like: > > drivers/usb/device/mpc8xx.c > drivers/usb/device/pxa27x.c > > or even > > drivers/usb/gadget/mpc8xx.c > drivers/usb/gadget/pxa27x.c > > to follow the Linux example a little more. > > Any comments? Hmm. Seems reasonable, especially if this structure will be used for all drivers. But is this the case? I still feel uncomfortable about placing a cpu dependant host controller driver in a generic driver directory. Will such a driver be maintained mainly by the USB Custodian or the respective Architecture Custodian? I would assume the latter. Best regards Markus -- DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany