[U-Boot-Users] What is CFG_CMD_ECHO for?

[U-Boot-Users] What is CFG_CMD_ECHO for?

[Sam Song]

Hi all,

I happened to find that the configuration CFG_CMD_ECHO
isn't be used in code at all but exist on README and 
is listed as Non-Default configuration. 

[root at sam u-boot]# grep -r CFG_CMD_ECHO ./
./README:               CFG_CMD_ECHO    * echo
arguments
./include/cmd_confdefs.h:#define CFG_CMD_ECHO         
 0x00080000ULL   /* echo arguments         */
./include/cmd_confdefs.h:                      
CFG_CMD_ECHO    | \
./include/configs/CRAYL1.h:     CFG_CMD_ECHO|\
......
./include/configs/PK1C20.h:                           
  CFG_CMD_ECHO   | \
./.#README.1.107:               CFG_CMD_ECHO    * echo
arguments
./.#README.1.108:               CFG_CMD_ECHO    * echo
arguments

In common/command.c, we can see that no any Macro 
defined before u-boot echo command.

So my puzzle come to know why keep this configuration?

Thanks for reading,

Sam

_________________________________________________________
Do You Yahoo!?
150??MP3????????????
http://cn.rd.yahoo.com/mail_cn/tag/yisou/music/*http://music.yisou.com/
???????????????????
http://cn.rd.yahoo.com/mail_cn/tag/yisou/image/*http://image.yisou.com
1G??1000???????????
http://cn.rd.yahoo.com/mail_cn/tag/1g/*http://cn.mail.yahoo.com/event/mail_1g/

[U-Boot-Users] What is CFG_CMD_ECHO for?

[Detlev Zundel]

Hi Sam,

> I happened to find that the configuration CFG_CMD_ECHO
> isn't be used in code at all but exist on README and 
> is listed as Non-Default configuration. 
>

[...]

> In common/command.c, we can see that no any Macro 
> defined before u-boot echo command.
>
> So my puzzle come to know why keep this configuration?

This indeed looks like hysterical cruft.  Do you mind throwing
together a patch to remove it?

Cheers
  Detlev

-- 
It was actually a very beautiful thing to see a sunrise, cause' that's
such a calm time of day. It's a wonderful time of day  to get ready to
go to bed.
                                            -- Richard M. Stallman

[U-Boot-Users] What is CFG_CMD_ECHO for?

[Sam Song]

--- Detlev Zundel <dzu@denx.de> wrote:
[snip]
> This indeed looks like hysterical cruft.  Do you
> mind throwing together a patch to remove it?

Wolfgang suggested me to send a patch as well. I 
promised to make it. But I cannot access the CVS
tree for the moment. Could I send the patch against 
1.1.2?

Thanks for your concern,

Sam

_________________________________________________________
Do You Yahoo!?
150??MP3????????????
http://cn.rd.yahoo.com/mail_cn/tag/yisou/music/*http://music.yisou.com/
???????????????????
http://cn.rd.yahoo.com/mail_cn/tag/yisou/image/*http://image.yisou.com
1G??1000???????????
http://cn.rd.yahoo.com/mail_cn/tag/1g/*http://cn.mail.yahoo.com/event/mail_1g/

[U-Boot-Users] What is CFG_CMD_ECHO for?

[Detlev Zundel]

Hi Sam,

> --- Detlev Zundel <dzu@denx.de> wrote:
> [snip]
>> This indeed looks like hysterical cruft.  Do you
>> mind throwing together a patch to remove it?
>
> Wolfgang suggested me to send a patch as well. I 
> promised to make it. But I cannot access the CVS
> tree for the moment. Could I send the patch against 
> 1.1.2?

Regarding the potential wasted time I'd say send a patch against TOT
when your CVS access is back up.

TIA
  Detlev

-- 
Practice random senselessness and act kind of beautiful.