U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Weijie Gao <weijie.gao@mediatek.com>
Cc: <u-boot@lists.denx.de>,
	 GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
	 Tom Rini <trini@konsulko.com>, Vignesh R <vigneshr@ti.com>,
	 Takahiro Kuwano <takahiro.kuwano@infineon.com>,
	 Marek Vasut <marek.vasut+renesas@mailbox.org>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Jeffrey Yu <jeyu@issi.com>,
	 Christoph Reiter <christoph.reiter@evk.biz>,
	 Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>,
	 Shiji Yang <yangshiji66@outlook.com>,
	"Bernhard Messerklinger" <bernhard.messerklinger@at.abb.com>,
	 Vaishnav Achath <vaishnav.a@ti.com>,
	 Prasad Kummari <prasad.kummari@amd.com>
Subject: Re: [PATCH 4/6] mtd: spi-nor-ids: Add 4K page support for Macronix MX25L25635E
Date: Tue, 28 Apr 2026 09:22:18 +0200	[thread overview]
Message-ID: <87cxzjft1x.fsf@bootlin.com> (raw)
In-Reply-To: <5fd1dfc2637fdc2f33b8ba68b46a35f8f320a6d1.1777345877.git.weijie.gao@mediatek.com> (Weijie Gao's message of "Tue, 28 Apr 2026 11:32:03 +0800")

Hi,

On 28/04/2026 at 11:32:03 +08, Weijie Gao <weijie.gao@mediatek.com> wrote:

> The datasheet can be found here:
> https://www.mxic.com.tw/Lists/Datasheet/Attachments/8592/MX25L25635E,%203V,%20256Mb,%20v1.3.pdf

You can be a little more verbose here, about the why we need this?

> @@ -330,7 +330,7 @@ const struct flash_info spi_nor_ids[] = {
>  	{ INFO("mx25u51245g", 0xc2253a, 0, 64 * 1024, 1024, SECT_4K |
>  	       SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
>  	{ INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) },
> -	{ INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SECT_4K |
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

Is this something you really need to flag? Isn't it already provided by
the SFDP tables?

>  	{ INFO("mx25u25635f", 0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) },
>  	{ INFO("mx25v8035f",  0xc22314, 0, 64 * 1024,  16, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  	{ INFO("mx25r1635f",  0xc22815, 0, 64 * 1024,  32, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

Thanks,
Miquèl

  reply	other threads:[~2026-04-28  7:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28  3:28 [PATCH 0/6] Fix and add some spi-nor flash parts Weijie Gao
2026-04-28  3:31 ` [PATCH 1/6] mtd: spi-nor-ids: Correct flash flags for ESMT/EON flashes Weijie Gao
2026-04-28  3:31 ` [PATCH 2/6] mtd: spi-nor-ids: Add support for ESMT/EON EN25QX128A/EN25QH256/EN25QX256A Weijie Gao
2026-04-28  3:32 ` [PATCH 3/6] mtd: spi-nor-ids: Add support for GigaDevice GD25Q256 Weijie Gao
2026-04-28  3:32 ` [PATCH 4/6] mtd: spi-nor-ids: Add 4K page support for Macronix MX25L25635E Weijie Gao
2026-04-28  7:22   ` Miquel Raynal [this message]
2026-04-28  7:26     ` Weijie Gao
2026-04-28  3:32 ` [PATCH 5/6] mtd: spi-nor-ids: Fix Winbond W25Q256JW and remove W25Q256FW Weijie Gao
2026-04-28  7:41   ` Miquel Raynal
2026-04-28  3:32 ` [PATCH 6/6] mtd: spi-nor-ids: Add support for Winbond W25Q256JV/W25Q512JV Weijie Gao
2026-04-28  7:45   ` Miquel Raynal
2026-04-28  8:37     ` Weijie Gao
2026-04-28  8:52       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cxzjft1x.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=GSS_MTK_Uboot_upstream@mediatek.com \
    --cc=bernhard.messerklinger@at.abb.com \
    --cc=christoph.reiter@evk.biz \
    --cc=jeyu@issi.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=prasad.kummari@amd.com \
    --cc=takahiro.kuwano@infineon.com \
    --cc=trini@konsulko.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=vaishnav.a@ti.com \
    --cc=venkatesh.abbarapu@amd.com \
    --cc=vigneshr@ti.com \
    --cc=weijie.gao@mediatek.com \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox